Stuart Henderson <st...@openbsd.org> writes: > On 2013/12/08 14:09, Claudio wrote: >> It's my first port, pqiv is a minimalist image viewer inspired by qiv. >> >> Claudio > > > Not tried building it yet, but a few comments from reading: > >> COMMENT= very small and pretty fast gdk/Imlib image viewer >> COMMENT= command line image viewer, replacement for qiv > > two COMMENTs? also this is missing the rcs id line.
I suggested the following changes so that Claudio could push them upstream. The changes were accepted and should be in pqiv-2.1: https://github.com/phillipberndt/pqiv/issues/17 If 2.0 has to be imported then I guess a lighter patch could be used. >> +MANDIR=$(PREFIX)/share/man > > I'd just patch the install target to use ${PREFIX}/man/man1 rather > than add this indirection. > >> install: pqiv$(EXECUTABLE_EXTENSION) >> - install -D pqiv$(EXECUTABLE_EXTENSION) >> $(DESTDIR)$(PREFIX)/bin/pqiv$(EXECUTABLE_EXTENSION) >> - install -D pqiv.1 $(DESTDIR)$(PREFIX)/share/man/man1/pqiv.1 >> + mkdir -p $(DESTDIR)$(PREFIX)/bin >> + install pqiv$(EXECUTABLE_EXTENSION) >> $(DESTDIR)$(PREFIX)/bin/pqiv$(EXECUTABLE_EXTENSION) >> + mkdir -p $(DESTDIR)$(MANDIR)/man1 >> + install pqiv.1 $(DESTDIR)$(MANDIR)/man1/pqiv.1 > > no need for mkdir here, but this is missing handling for stripping. > so actually, rather than patch this at all, it's such a simple case that > it's probably easier to use a custom do-install target in the port Makefile. > >> uninstall: >> rm -f $(DESTDIR)$(PREFIX)/bin/pqiv$(EXECUTABLE_EXTENSION) >> - rm -f $(DESTDIR)$(PREFIX)/share/man/man1/pqiv.1 >> + rm -f $(DESTDIR)$(MANDIR)/man1/pqiv.1 > > we won't run this, so no need to patch the uninstall target -- jca | PGP: 0x06A11494 / 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494
