QML and paths to images

2012-06-09 Thread Dmitry
Hello! I'm working on implementation of system tray in QML. Is it possible to get absolute path to icon/image/movie in QML? I need to put into QML code AnimatedImage item, but it requires a full path to a movie (animation). I have only name of movie instead of its full path. Thank you! __

Re: QML and paths to images

2012-06-09 Thread Dmitry
09.06.2012 18:39, Aaron J. Seigo пишет: On Saturday, June 9, 2012 16:27:38 Dmitry wrote: I'm working on implementation of system tray in QML. Is it possible to get absolute path to icon/image/movie in QML? I need to put into QML code AnimatedImage item, but it requires a full path to a

Re: QML and paths to images

2012-06-09 Thread Dmitry
09.06.2012 19:21, Aaron J. Seigo пишет: On Saturday, June 9, 2012 18:56:46 Dmitry wrote: Animations are in /usr/share/icons// and if I use C++ I'll load them using KIconLoader::loadMovie(). ah .. from icons. hm. question: is the QML implementation you are working on pure QML, or is it

Plasma applets inside QML applet

2012-06-23 Thread Dmitry
Hello! I'm developing an applet in QML. I need to load an external applet and to place it into my applet like containment applet, like panel or system tray. But at the same time my applet isn't a pure containment applet [it doesn't contain only applets]. Do You know how I can do it or it's n

Re: Plasma applets inside QML applet

2012-06-25 Thread Dmitry
25.06.2012 13:24, Marco Martin пишет: On Monday 25 June 2012, Dmitry Ashkadov wrote: Hello! I'm trying to implement a system tray in QML. So, I have a trouble with applets such as battery, notifier, notifications. They [applets] should be mixed with icons of applications and tray must ha

Re: Plasma applets inside QML applet

2012-06-27 Thread Dmitry
Hello! I've found out a strange behaviour. If I place embedded applet into panel part of tray then the embedded applets look well and work. But If I place them into popup dialog then they look strange and don't work at all. It seems that plasma automatically places their extended/popup form i

Pop-up dialog of embedded applets

2012-07-03 Thread Dmitry
Hello, Marco! I'm implementing system tray in QML. I've found a solution how to place embedded applet into pop-up window of tray. But there is one difference between my system tray [in QML] and your current system tray [in pure C++]. If some embedded applet is placed in pop-up window of system

Re: Pop-up dialog of embedded applets

2012-07-05 Thread Dmitry
03.07.2012 16:44, Dmitry ?: Hello, Marco! I'm implementing system tray in QML. I've found a solution how to place embedded applet into pop-up window of tray. But there is one difference between my system tray [in QML] and your current system tray [in pure C++]. If some embedded

Complex configuration dialog for pure QML applet

2012-07-17 Thread Dmitry
Hello! I'm trying to implement system tray in QML. I'm trying to implement configuration dialog (widget). Pure QML-based applet "devicenotifier" is an example of implementation of configuration dialog for QML applet. But it has only 3 simple radio buttons in its configuration dialog. Its way

Re: Complex configuration dialog for pure QML applet

2012-07-17 Thread Dmitry
17.07.2012 18:18, Marco Martin пишет: in this particular case, i would say is the best way to go anyways, since a systray replacement to be complete needs to support also the old x11 protocol and i really want to avoid applets with their own c++ import, thinking to formalize this requirement (n

Re: Complex configuration dialog for pure QML applet

2012-07-17 Thread Dmitry
17.07.2012 18:18, Marco Martin пишет: i really want to avoid applets with their own c++ import, thinking to formalize this requirement (nothing installed in imports) for plasmoids to be included by default Does such list of requirements exist? Is it published? Thank you/ _

System tray: configuration dialog

2012-07-20 Thread Dmitry
Hello! What do you think about removing column allowing setting the hot-keys (shortcuts) for every tray task/application/embedded applet? Thank you! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

System tray: project

2012-07-20 Thread Dmitry
Hello, Marco! What do you think about: * should I use code of current system tray (i.e. git clone & git branch ) to include system tray in QML in KDE or create new clean project (i.e. git init) and push it [new project] to playground? Should system tray in QML be an continuation of tra

Re: System tray: project

2012-07-20 Thread Dmitry
20.07.2012 14:15, Marco Martin пишет: in this case it should be a branch of the kde-workspace repo, they are usually named project/youraccountname/featurename, so would be something like plasma/dmitry/qmlsystemtray So, can I create new branch in kde-workspace (I'm asking for a permissi

PlasmaCore.ToolTip

2012-07-30 Thread Dmitry
Hello! Does PlasmaCore.ToolTip support icons specified as QIcon (not by name of icon) ? Thank you! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: PlasmaCore.ToolTip

2012-07-30 Thread Dmitry
30.07.2012 13:33, Marco Martin пишет: On Monday 30 July 2012, Dmitry wrote: Hello! Does PlasmaCore.ToolTip support icons specified as QIcon (not by name of icon) ? Thank you! no, at the moment only icon name. i guess is to support both types of systray icons? it should be possible to change

Re: Current state of System Monitor

2012-08-07 Thread Dmitry
07.08.2012 12:25, Marco Martin пишет: On Tuesday 07 August 2012, Peter Hartmann wrote: Hello I'd like to inquire if QML port of System Monitor applet is in work or in plans for near future. There is only C++ code in repo, but revision history tells me that there were such attempts in the past.

Re: Current state of System Monitor

2012-08-07 Thread Dmitry
07.08.2012 13:16, Marco Martin пишет: On Tuesday 07 August 2012, Dmitry wrote: Hello! I'm working on my new system monitor applet. I hate current default C++ applet. So, I've decided to implement my simple system monitor in pure QML (no C++ code at all). At the same time I don't

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
08.08.2012 17:13, Mark пишет: On Tue, Aug 7, 2012 at 12:55 PM, Dmitry wrote: 07.08.2012 13:16, Marco Martin пишет: On Tuesday 07 August 2012, Dmitry wrote: Hello! I'm working on my new system monitor applet. I hate current default C++ applet. So, I've decided to implement my sim

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 14:27, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: http://doc-snapshot.qt-project.org/5.0/qml-qtquick2-context2d.html Hello, Mark! I think, you haven't understood me right. I don't want to port current C++ system monitor applet because it hasn't b

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 15:10, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: by the way that's what the formfactor mechanism for plasmoids is for. the same plasmoid should adapt itself for an optimal visualization wether is in the desktop, an horizontal panel or a vertical one, just

Re: Current state of System Monitor

2012-08-09 Thread Dmitry
09.08.2012 18:08, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: 09.08.2012 15:10, Marco Martin пишет: On Thursday 09 August 2012, Dmitry wrote: by the way that's what the formfactor mechanism for plasmoids is for. the same plasmoid should adapt itself for an op

Translations

2012-08-13 Thread Dmitry
Hello! If current C++ system tray applet doesn't run then QML system tray will have configuration dialog with untranslated string. Do you know why it may occur? Thank you! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailm

System tray: size of icons

2012-08-14 Thread Dmitry
Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray doesn't fix size of icons (plasmoids). For example, battery may be larger that other icons. It looks very strange: I assumed that all i

Re: System tray: size of icons

2012-08-14 Thread Dmitry
14.08.2012 21:01, Marco Martin пишет: On Tuesday 14 August 2012, Dmitry wrote: Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray doesn't fix size of icons (plasmoids). For ex

Re: System tray: size of icons

2012-08-14 Thread Dmitry
14.08.2012 21:59, Dmitry пишет: 14.08.2012 21:01, Marco Martin пишет: On Tuesday 14 August 2012, Dmitry wrote: Hello! I thought that all icons in tray have to be the same size (i.e. to be limited in size), but current C++ system tray

Re: Translations

2012-08-14 Thread Dmitry
15.08.2012 03:19, Alexander Potashev пишет: Hi Dmitry, (I'm CC'ing the KDE localization mailing list.) This happens due to missing code that would import required translation catalogs (.po files), for example: KGlobal::locale()->insertCatalog( "kcm_akonadi"

System tray

2012-09-18 Thread Dmitry
Hello, Marco! Could you try a system tray from plasma/dmitrya/systemtray-qml branch of kde-workspace? What do you think about popup window? Maybe will it better if icons in popup are placed like a grid? Thank you! ___ Plasma-devel mailing list Plasm

PopupApplet and setFocus() behaviour

2009-08-12 Thread Dmitry Suzdalev
. I don't want to use a timer as that's not 100% fix and can lead to users noticing a slight delay. In the end I want to simply ensure that my widget will always have focus when shown in a popup. Is this possible? Is there some potential workaround you see? Thanks in advance, D

PopupApplet and setFocus() behaviour

2009-08-13 Thread Dmitry Suzdalev
. I don't want to use a timer as that's not 100% fix and can lead to users noticing a slight delay. In the end I want to simply ensure that my widget will always have focus when shown in a popup. Is this possible? Is there some potential workaround you see? Thanks in advance, D

Re: PopupApplet and setFocus() behaviour

2009-08-14 Thread Dmitry Suzdalev
On Friday 14 August 2009 00:32:09 Marco Martin wrote: > On Thursday 13 August 2009, Dmitry Suzdalev wrote: > > Hi guys and girls! > > > > While making some progress on klipper engine+applet I discovered some > > oddities with focus behavior. I hope you can give me some h

Re: PopupApplet and setFocus() behaviour

2009-08-18 Thread Dmitry Suzdalev
temporary or offscreen for ex) widget on the scene. That is we don't wont a focusOut event coming to the widget right after we told it to focusIn :) Cheers, Dmitry. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Add setSubTitlePolicy() method to Plasma::Delegate

2009-08-18 Thread Dmitry Suzdalev
/diff Testing --- Tested with klipper applet by putting it in all modes possible (at least all i can come up with :)) Thanks, Dmitry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add setSubTitlePolicy() method to Plasma::Delegate

2009-08-18 Thread Dmitry Suzdalev
/delegate.cpp 1011618 Diff: http://reviewboard.kde.org/r/1357/diff Testing --- Tested with klipper applet by putting it in all modes possible (at least all i can come up with :)) Thanks, Dmitry ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Add setSubTitlePolicy() method to Plasma::Delegate

2009-08-20 Thread Dmitry Suzdalev
ain point now is to leave only checking for data validity of SubTitleMandatoryRole, and do disambiguating *only* if model doesn't care. I've yet to update this review with the actual patch. - Dmitry --- This is an automatically generated

Re: Review Request: Add setSubTitlePolicy() method to Plasma::Delegate

2009-08-21 Thread Dmitry Suzdalev
/delegate.h 1010706 trunk/KDE/kdelibs/plasma/delegate.cpp 1010706 Diff: http://reviewboard.kde.org/r/1357/diff Testing --- Tested with klipper applet by putting it in all modes possible (at least all i can come up with :)) Thanks, Dmitry

Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Dmitry Suzdalev
. Task items retain their sort order, not reacting to title changes, charming :) It affects only task applets with sort mode set to "by desktop" Thanks, Dmitry ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-23 Thread Dmitry Suzdalev
gt; > can be just "else if (leftWinIdIsValid)" since we know both aren't due > > to the initial if. yes, thanks > On 2010-03-23 22:05:51, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/libs/tas

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-29 Thread Dmitry Suzdalev
libs/taskmanager/strategies/desktopsortingstrategy.cpp 1105271 Diff: http://reviewboard.kde.org/r/3375/diff Testing --- Tested on trunk. Task items retain their sort order, not reacting to title changes, charming :) It affects only task applets with sort mode set to "by desktop"

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-29 Thread Dmitry Suzdalev
<http://reviewboard.kde.org/r/3375/#comment4263> Hmm, just thought that I probably should make it non-virtual. having it to be virtual might be useful, but it will break the guarantee of non-repeatable IDs that is currently provided by a base class. - Dmitry On 2010-03-29

Re: Review Request: Fix taskmanager's "by desktop" sorting mode

2010-03-29 Thread Dmitry Suzdalev
lems. But I guess the real fix should be in layouting classes in tasks applet, but it's source is not so trivial, I need to study the code more. So perhaps it'll need to wait to fix this in the right place. I'll try to dig in and report when done :)

Re: plasma-windowed moved to kdereview

2010-04-26 Thread Dmitry Suzdalev
reen "apps". > > it has been moved into kdereview/plasma/shells/plasma-windowed > > the plan is to move it into kdebase/workspace/plasma/generic/shells/ wow that sounds like catching a two hares at once :) Nice feature(s) :) Cheers, Dmitry. ___

Re: Plasma applets inside QML applet

2012-06-25 Thread Dmitry Ashkadov
n the background of the problem. Regards, Djuro Drljaca On Sat, Jun 23, 2012 at 10:33 PM, Dmitry wrote: Hello! I'm developing an applet in QML. I need to load an external applet and to place it into my applet like containment applet, like panel or system tray. But at the same time my appl

Re: SystemTray: QML version #2

2012-10-15 Thread Dmitry Ashkadov
15.10.2012 20:20, Aaron J. Seigo ?: On Monday, October 15, 2012 19:20:13 Dmitry Ashkadov wrote: i do notice some small visual issues in the screenshots (thanks for providing those, btw!), mostly to do with spacing and margins in the popup. as you can see in image 05, there is not enough

Re: SystemTray: QML version #2

2012-10-17 Thread Dmitry Ashkadov
Hello! 15.10.2012 21:36, Marco Martin пишет: as aaron also noted, if the text is very large seems it can go out of boundaries (seen in http://wstaw.org/m/2012/10/15/plasma-desktopO28633.png), probably the popup should expand until a certain width in characters, and then elide the entries text if

SystemTray: QML version #3

2012-10-17 Thread Dmitry Ashkadov
Hello! I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): * Now the arrow will hide if popup dialog contains no items * Some distances between items in popup dialog have been increased * A new approach to the problem of co

Re: SystemTray: QML version #2

2012-10-18 Thread Dmitry Ashkadov
18.10.2012 22:29, Aaron J. Seigo пишет: On Wednesday, October 17, 2012 17:52:58 Dmitry Ashkadov wrote: 15.10.2012 20:20, Aaron J. Seigo ?: i do notice some small visual issues in the screenshots (thanks for providing those, btw!), mostly to do with spacing and margins in the popup. as you

Where should QML stuff be placed to?

2012-10-19 Thread Dmitry Ashkadov
Hello! I'm working on QML implementation of system tray for desktop. But I don't know where the QML stuff (files *.qml & *.js) should be placed to. I have found out that there are 3 places. Let be share directory for applications (usually it /usr/share/apps ) and be a name of application/p

Re: SystemTray: QML version #2

2012-10-19 Thread Dmitry Ashkadov
19.10.2012 11:59, Marco Martin пишет: On Friday 19 October 2012, Dmitry Ashkadov wrote: we should get this merged into master sooner rather than later. if it has all the features of the C++ one, i'd like to see that happen, well, tomorrow :) Hello! QML tray have all features of C++

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
--- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
eel.button have type QVariant, so it's impossible to use switch (mouse.button) { case Qt.LeftButton: ... }. At the same time Qt's MouseArea has different behaviour — switch (mouse.button) { case Qt.RightButton: ... } works - Dmitry -

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
which cannot be scaled(?) since they are not > > actual icons, but I think they should be shown centered inside the bigger > > cell then. (and the only app I regularly use that still uses XEmbed is > > Skype) I can try do this, But how can user set size of icons? There is no such o

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
essary, a wheelevent was added in > > org.kde.qtextracomponents in MouseEventListener > > > > the TODO of replacing this in qt5 stays, but is a c++ file less > > > > see > > http://api.kde.org/4.x-api/kde-runtime-apidocs/plasma/html/classMouseEventListener.html > >

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
which cannot be scaled(?) since they are not > > actual icons, but I think they should be shown centered inside the bigger > > cell then. (and the only app I regularly use that still uses XEmbed is > > Skype) > > Dmitry Ashkadov wrote: > I can try do this, But how can

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
which cannot be scaled(?) since they are not > > actual icons, but I think they should be shown centered inside the bigger > > cell then. (and the only app I regularly use that still uses XEmbed is > > Skype) > > Dmitry Ashkadov wrote: > I can try do this, But how can

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
org.kde.core.Dialog to hide dialog from taskbar. So, custom implementation of dialog may be removed. - Dmitry Ashkadov On Oct. 22, 2012, 9:19 a.m., Dmitry Ashkadov wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request: Implementation of System tray in QML

2012-10-22 Thread Dmitry Ashkadov
/systemtray/ui/widgetitem.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106965/diff/ Testing --- Screenshots --- Example http://git.reviewboard.kde.org/r/106965/s/788/ Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
22.10.2012 19:17, Luca Beltrame пишет: In data giovedì 18 ottobre 2012 09:50:49, Dmitry Ashkadov ha scritto: Hello, I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): I've been playing with this for a bit and I

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok& km

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:51, Marco Martin пишет: On Tuesday 23 October 2012, Dmitry Ashkadov wrote: 23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've

Review Request: Possibility to set QIcon to PlasmaCore.Tooltip

2012-10-23 Thread Dmitry Ashkadov
: http://git.reviewboard.kde.org/r/107013/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
use I will can eliminate usage of Svg QML items for arrow and Dbus tasks in system tray. Diffs - plasma/widgets/iconwidget.h 78f392e plasma/widgets/iconwidget.cpp a2092a4 Diff: http://git.reviewboard.kde.org/r/107017/diff/ Testing --- Thanks, Dmitry Ash

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
sting --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-24 Thread Dmitry Ashkadov
et.h 78f392e plasma/widgets/iconwidget.cpp a2092a4 Diff: http://git.reviewboard.kde.org/r/107017/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Dmitry Ashkadov
sing SVG > > files. IconWidget supports QAction so it's possible to handle global shortcuts. Does QML Button support QAction? Or is is another way to handle global shortcuts from QML? - Dmitry --- This is an automatica

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 00:43, Aaron J. Seigo пишет: hi... i suppose this is mostly for Dmitry, but its nice to have these discussions here :) so .. system tray plasmoid. works pretty well it seems. :) Hello! Thank you for your questions! But first of all, I'd like to know what branch should I u

Re: qml systemtray: small refactorings

2012-10-25 Thread Dmitry Ashkadov
26.10.2012 09:51, Luca Beltrame пишет: In data venerdì 26 ottobre 2012 09:40:25, Dmitry Ashkadov ha scritto: branch should I use to make some refactoring/changes? As I know today 4.10 branch must be created. Today marks the *soft* feature freeze: in other words, not yet frozen for new

Re: qml systemtray: small refactorings

2012-10-26 Thread Dmitry Ashkadov
26.10.2012 10:50, Aaron J. Seigo пишет: On Friday, October 26, 2012 10:04:24 Dmitry Ashkadov wrote: Thank you for your answer. What workflow does KDE team use to bring changes from master branch to KDE4.X branch? For example, some fixes should be applied to master and KDE4.X branches at the

Re: qml systemtray: small refactorings

2012-10-26 Thread Dmitry Ashkadov
26.10.2012 12:38, Aaron J. Seigo пишет: On Friday, October 26, 2012 11:35:57 Dmitry Ashkadov wrote: Thank you! Is somebody who periodically merges KDE 4.X to master or it must be made by who fixes bug? the bug fixer; kdelibs is different -> it is merged periodically by someone (usually dfa

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
Hello! First of all, it a good idea! 1. I think you should explain why you have chosen such style instead of another one. Your decision should be justified. For example: I don't understand why you put brace on new line in case of function. As for me it's terrible because I need always rememb

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 13:15, Aaron J. Seigo пишет: On Tuesday, October 30, 2012 12:25:14 Dmitry Ashkadov wrote: First of all, it a good idea! :) 1. I think you should explain why you have chosen such style instead of another one. Your decision should be justified. this is the death of style guides

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 14:35, Aaron J. Seigo пишет: 5. Vim: The {{{ and }}} are just for the sakes of vim's automatic folding. Do we all use vim? I think no. So, we must never force developers use vim. i mostly agree :) i don't think this forces anyone to use vim, but i would like to see a solution that

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 16:01, Sebastian Kügler пишет: There, the JS code should probably be in the QML file itself, as that's the only place where it's used. For the shared code, you'd import: import "plasmapackage:/code/statelesslib.js" as StatelessLib There is page in documentation http://qt-project.o

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 17:20, Marco Martin пишет: On Tuesday 30 October 2012, Dmitry Ashkadov wrote: 30.10.2012 16:01, Sebastian Kügler пишет: There, the JS code should probably be in the QML file itself, as that's the only place where it's used. For the shared code, you'd import: import

Re: QML style guide

2012-10-30 Thread Dmitry Ashkadov
30.10.2012 21:33, Martin Gräßlin пишет: On Tuesday 30 October 2012 18:16:26 Aurélien Gâteau wrote: The only part I don't really like is putting left curly brace on its own line for functions because: - having different conventions for event-handlers and function code blocks look inconsistent -

Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-10-31 Thread Dmitry Ashkadov
hanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
tem tray plasmoid. > > (look for s_manager) this keeps memory usage and dbus activity down. so > > this approach can not work. So, task will have no widget property and WidgetItem will know about Task (not only QGraphicsWidget). - Dmitry ---

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Dmitry Ashkadov
tem tray plasmoid. > > (look for s_manager) this keeps memory usage and dbus activity down. so > > this approach can not work. > > Dmitry Ashkadov wrote: > So, task will have no widget property and WidgetItem will know about Task > (not only QGraphicsWidget). And doe

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-02 Thread Dmitry Ashkadov
temtray/ui/widgetitem.h 40aa92d plasma/generic/applets/systemtray/ui/widgetitem.cpp 9d2c622 Diff: http://git.reviewboard.kde.org/r/107160/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
tItem won't work, because it is used in QML to determine the location/area where the task will be placed (popup dialog or panel). - Dmitry --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.or

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Review Request: SystemTray: Removing IconWidget for an arrow

2012-11-07 Thread Dmitry Ashkadov
--- IconWidget should be removed from QML. It may be replaced with SvgItem for an arrow. Diffs - plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml a3d7f39 Diff: http://git.reviewboard.kde.org/r/107239/diff/ Testing --- Thanks, Dmitry Ashkadov

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
Diff: http://git.reviewboard.kde.org/r/107160/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Dmitry Ashkadov
lasma, and once one gets used to it > > things become easier :) > > > > anyways.. this one small change of moving the hiding status from Task to > > WidgetItem and this can be pushed into master :) > > > > thanks ... > > Dmitry Ashkadov wrote: > M

Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
/107262/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Dmitry Ashkadov
> On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: > > nice work :) it's really coming into a very good shape ... But there is one problem: property id of Plasma::Applet isn't a constant for now, so, there are warnings in

Review Request: SystemTray: alignment of popup dialog

2012-11-19 Thread Dmitry Ashkadov
dialog of system tray has been fixed and set to Qt.AlignCenter Diffs - plasma/generic/applets/systemtray/package/contents/ui/ArrowArea.qml 336f052 Diff: http://git.reviewboard.kde.org/r/107378/diff/ Testing --- Thanks, Dmitry Ashkadov

Review Request: Move IconItem into MouseArea

2012-12-23 Thread Dmitry Ashkadov
gs.kde.org/show_bug.cgi?id=311961 Diffs - plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml 8c1af92 Diff: http://git.reviewboard.kde.org/r/107886/diff/ Testing --- Thanks, Dmitry Ashkadov ___ Plasma-devel mailing l

Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
ith it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov ___ Plasma-devel mailing list Plasma-deve

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
ay.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov __

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
to fix the issue). There's "TODO" file in plasma/generic/applets/systemtray with item "Fix sizing on desktop" which seems at least related to the discussed bug. Perhaps I should email to the creator of this file to ask w

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
ay.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov __

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
rom 4.11.3 to 4.13.1 (coming with Linux Mint updates). Could it be counted as some testing? - Dmitry --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
g --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray app

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
src/platformtheme/kdeplatformsystemtrayicon.cpp 51f31ad Diff: https://git.reviewboard.kde.org/r/121439/diff/ Testing --- Thanks, Dmitry Shachnev ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121439/#review71787 --- Ship it! Ship It! - Dmitry Shachnev On Dez. 11, 2014, 8

Re: Review Request 121439: systemtrayicon: pass icon’s name(), not themeName() to showMessage

2014-12-11 Thread Dmitry Shachnev
> On Dez. 11, 2014, 10:42 vorm., Dmitry Shachnev wrote: > > Ship It! > > Martin Gräßlin wrote: > do you have commit rights or should someone push the change for you? No, I don't have rights. Actually this is my first contribution to KDE :) So please push it for me

  1   2   >