Questions for commit...

I have some questions if you could help me... in order to commit, one way is through "git push" the other is through "arc tool"... my question for the arc tool is this: 1. "I have a feature branch in git (with my commit) in a local branch that is not fully up to date with origin/master, what

commit through git close bug and phabricator diff?

One more question please, commiting only through git what do I have to add to my commit in order to close a phabricator diff and a bugzilla bug and where (in header or the comments?) for example, "fix D3282 368384" is going to close phabricator D3282 and bugzilla bug #368384? regards, mic

Re: commit through git close bug and phabricator diff?

On Sun, Nov 13, 2016 at 10:59 AM, Michail Vourlakos wrote: > One more question please, commiting only through git what do I have to add > to my commit in order to close a phabricator diff and a bugzilla bug and > where (in header or the comments?) > > > for example, "fix D3282 368384" is going to

Re: commit through git close bug and phabricator diff?

So if I read it correctly I can not close a phabricator diff through git comments... Στις 13 Νοε 2016 12:04 μ.μ., ο χρήστης "Elvis Angelaccio" < elvis.angelac...@kde.org> έγραψε: > On Sun, Nov 13, 2016 at 10:59 AM, Michail Vourlakos > wrote: > > One more question please, commiting only through gi

Re: commit through git close bug and phabricator diff?

On Sun, Nov 13, 2016 at 4:08 PM, Michail Vourlakos wrote: > So if I read it correctly I can not close a phabricator diff through git > comments... you can, You need to add following line Differential revision: https://phabricator.kde.org/D Thanks -- Bhushan Shah http://blog.bshah.in IRC

Re: commit through git close bug and phabricator diff?

Thank u !!! On Sunday, November 13, 2016, Bhushan Shah wrote: > On Sun, Nov 13, 2016 at 4:08 PM, Michail Vourlakos wrote: >> So if I read it correctly I can not close a phabricator diff through git >> comments... > > you can, > > You need to add following line > > Differential revision: https://

[Differential] [Commented On] D3282: add backgroundHints for the panel View (disable/enable Effects and shadows for a Panel)

mvourlakos added a comment. this has been commited !!! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma Cc: mart, brouli

[Differential] [Commented On] D3283: Hide Background for Panel when backgroundHints are used

mvourlakos added a comment. this has been committed!!! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma Cc: mart, plasma-dev

Re: commit through git close bug and phabricator diff?

you can, You need to add following line Differential revision: https://phabricator.kde.org/D Thanks I have just made two commits in plasma-desktop and workspace by using the following in the commit message: Differential Revision: https://phabricator.kde.org/D3283 but the correspondin

[Differential] [Closed] D3282: add backgroundHints for the panel View (disable/enable Effects and shadows for a Panel)

mvourlakos closed this revision. mvourlakos added a comment. commited... https://cgit.kde.org/plasma-workspace.git/commit/?id=341a534e9d16eaf89f137136bdbff5756db78775 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3282 EMAIL PREFERENCES

[Differential] [Closed] D3283: Hide Background for Panel when backgroundHints are used

mvourlakos closed this revision. mvourlakos added a comment. commited https://cgit.kde.org/plasma-desktop.git/commit/?id=b1bc4f8347fca280d7c44b2e76a40f9a7bdc44d4 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3283 EMAIL PREFERENCES https

[Differential] [Request, 18 lines] D3354: expose panel thickness to the client side

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY this is a way for the client panel implementation to access the thickness variable of the panel. th

[Differential] [Updated] D3354: expose panel thickness to the client side

mvourlakos added a reviewer: davidedmundson. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3354 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, davidedmundson Cc: plasma-devel, lesliezhai, ali-

[Differential] [Requested Changes To] D3354: expose panel thickness to the client side

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Panel.qml:75 > + > +if (containment.children[0]) { > +panelClient = containment.children[0]; We can't do this, it's making

[Differential] [Request, 28 lines] D3355: add maskArea in panel view

mvourlakos created this revision. mvourlakos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY enables a mask for the panel which can be used from transparent panels in order to set their working

[Differential] [Updated] D3354: expose panel thickness to the client side

mvourlakos updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3354 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, davidedmundson Cc: plasma-devel, lesliezhai,

[Differential] [Updated] D3355: add maskArea in panel view

mvourlakos added a reviewer: davidedmundson. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, davidedmundson Cc: plasma-devel, lesliezhai,

Re: [Discussion] - Plasma Panels Future Enhancements?

On Sat, Nov 12, 2016 at 1:35 PM, Michail Vourlakos wrote: > David, thanks a lot for the quick reply... > > How will that help your use case of the dock? > You control the containment in a panel, but you're not changing Panel.qml > itself. > > Everything should be exposed to the client already as

[Differential] [Commented On] D3354: expose panel thickness to the client side

mvourlakos added a comment. No problem for me, to implement an alternative if you can point me in the right direction... What we need then is an interface in order to give the client the possibility to set thickness and the maskArea, a patch which I have sent a little before... Mayb

[Differential] [Updated] D3355: add maskArea in panel view

davidedmundson added a comment. One thing to be careful of: The code in Qt is: void QWindow::setMask(const QRegion ®ion) { Q_D(QWindow); if (!d->platformWindow) return; d->platformWindow->setMask(QHighDpi::toNativeLocalRegion(region, this));

[Differential] [Commented On] D3355: add maskArea in panel view

davidedmundson added a comment. Also, to save anyone else also looking this up QWindow::setMask does work on Wayland. On the QPA side anyway. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3355 EMAIL PREFERENCES https://phabricator.kde.or

Re: [Discussion] - Plasma Panels Future Enhancements?

What do you mean by "the client"? Your containment? David I believe yes... I hope that we are talking for the same thing... :) by "the client" I mean my dock (container) michail

[Differential] [Commented On] D3355: add maskArea in panel view

mvourlakos added a comment. > So if you call setMask, before you call show() this will fail. by fail, you mean it wont work right (not crashing)? I have tested the code with my dock because i call the setMask many times during animations I will have to see what happens when it is