davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> Panel.qml:75
> +
> + if (containment.children[0]) {
> + panelClient = containment.children[0];
We can't do this, it's making an optimistic assumption about the ordering of
objects, which is prone to change.
If we go for this, it needs to be in some defined interface like we did for
backgroundHints.
I'm not sure quite what yet, I'll discuss back on your main thread.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D3354
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mvourlakos, davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
