Re: Review Request 118865: [startkde from plasma next] create ~/.kde directory if it doesn't exist

2014-07-12 Thread David Edmundson
> On July 12, 2014, 2:31 a.m., Xuetian Weng wrote: > > That code snippet is from Qt, since it was written before kf5 release, it > > doesn't know kf5 is already goes XDG standard, hence I think it should be > > reported against Qt 5. You're right about that code being in Qt, but we /should/ be

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62170 --- Ship it! Ship It! - David Edmundson On July 11, 2014, 2:35

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread David Edmundson
> On July 11, 2014, 2:48 p.m., Sebastian Kügler wrote: > > It would be easier to review, if you made separate patches for the renaming > > and the actual changes in the code that juggle around the objects. > > Martin Klapetek wrote: > I did the renaming in the middle of this as I got annoye

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/ --- (Updated July 12, 2014, 11:52 a.m.) Status -- This change has been m

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-12 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119025/ --- (Updated Июль 12, 2014, 5:12 п.п.) Review request for kde-workspace, Plas

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119232/#review62191 --- To be honest I'm not happy with the visual results in either v

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread Martin Klapetek
> On Čec. 12, 2014, 4:55 odp., Eike Hein wrote: > > To be honest I'm not happy with the visual results in either version, the > > bright puxels from overlaps are ugly. Why can't we use a single Canvas > > element to paint it all properly instead of using rects? I've moved the inner lines to be

Plasma shell -> Mediacenter

2014-07-12 Thread Shantanu Tushar Jha
Hi folks, The frameworks branch of PMC now contains a Plasma Shell which basically loads the required QML components and looks/works exactly the same[1]. So technically we are good to go if a user wants her desktop to be a media center. However, it'll be nice if we can discuss on how the actual w

Re: Plasma shell -> Mediacenter

2014-07-12 Thread Andres Silva
Shantanu Tushar Jha wrote: Hi folks, The frameworks branch of PMC now contains a Plasma Shell which basically loads the required QML components and looks/works exactly the same[1]. So technically we are good to go if a user wants her desktop to be a media center. However, it'll be nice if we ca

Review Request 119250: Events and trips according to date ranges

2014-07-12 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/ --- Review request for Plasma. Repository: plasma-mediacenter Description -

Re: Review Request 119250: Events and trips according to date ranges

2014-07-12 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/ --- (Updated July 12, 2014, 6:13 p.m.) Review request for Plasma. Changes -

Re: Review Request 119250: Events and trips according to date ranges

2014-07-12 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62199 --- browsingbackends/metadatabackends/eventsbackend/eventsbackend

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread David Edmundson
> On July 12, 2014, 2:55 p.m., Eike Hein wrote: > > To be honest I'm not happy with the visual results in either version, the > > bright puxels from overlaps are ugly. Why can't we use a single Canvas > > element to paint it all properly instead of using rects? > > Martin Klapetek wrote: >

Re: Review Request 119250: Events and trips according to date ranges

2014-07-12 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119250/#review62215 --- I liked the interface and the idea, +1 for that. Some of the

Re: Review Request 119232: Rewrite the Calendar component grid + small refactor

2014-07-12 Thread Jens
> I don't get why they're brighter anyway. borderOpacity is 1.0, so if they > overlap that shouldn't have any impact? > > > - David Just a shot in the dark here but if its two vector lines on top of each other the bitmap version of them tend to be "a tad more than the exact line width" making

Review Request 119252: Use KXMLGUI_INSTALL_DIR instead of DATA_INSTALL_DIR for .rc files

2014-07-12 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119252/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 119252: Use KXMLGUI_INSTALL_DIR instead of DATA_INSTALL_DIR for .rc files

2014-07-12 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119252/ --- (Updated July 12, 2014, 11:03 p.m.) Review request for Plasma. Reposito