-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119250/#review62215
-----------------------------------------------------------


I liked the interface and the idea, +1  for that.

Some of the issues that I faced are(brief testing):

    1. Create an event -> Exit PMC -> add new event -> unable to do so :(
    2. [Logical] Was able to create an event/trip from October to July
    3. Something that I couldn't figure out, how do I add content to the 
trip/event folders ?
       Edit option only allows me to change the timeline, should have an option 
to add/remove images. 

Otherwise, this would be nice feature to have in PMC. Besides, 2 would be a 
junior job that someone else could attempt to fix, not critical but pointed it 
out nevertheless.

- R.Harish  Navnit


On July 12, 2014, 6:13 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119250/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 6:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> I got this idea on a recent trip that usually a family would have a device 
> where they store their trips/events photos on. Easier than tagging 
> everything, what if you could just say "Hey, I went to Kashmir during 5 April 
> to 14 April 2014" and voila!
> 
> This backend implements this idea in a (hopefully) easy-to-use way. I'll love 
> to hear some feedback around this :)
> 
> 
> Diffs
> -----
> 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/CMakeLists.txt ae56603 
>   browsingbackends/metadatabackends/eventsbackend/CMakeLists.txt PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.h 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventspicturesmodel.cpp 
> PRE-CREATION 
>   libs/mediacenter/backendsmodel.cpp 2823fb6 
>   libs/mediacenter/filtermediamodel.h b8272f6 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.desktop 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsbackend.h 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/DatePicker.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/Digit.qml 
> PRE-CREATION 
>   
> browsingbackends/metadatabackends/eventsbackend/eventscomponents/EventsConfiguration.qml
>  PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventscomponents/qmldir 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.h 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsfiltermodel.cpp 
> PRE-CREATION 
>   browsingbackends/metadatabackends/eventsbackend/eventsmodel.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119250/diff/
> 
> 
> Testing
> -------
> 
> Seems to work as expected, I will be attaching screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Showing events
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/c4c99bbd-f77f-4167-922e-79f90949040b__events.png
> Showing photos from an event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/a4ed7663-64b6-4963-aed3-5e41cc8e51ee__showing-event.png
> Editing dates of an existing event
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/07/12/965b667b-e209-44a3-bc64-95f81b18913e__editing-event.png
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to