Re: plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Marco Martin
At some point we decided we wanted to ship plasmoids in qrc files. we started to do it, but then between bugs, and people strongly disagreeing we reverted all of it just before the plasma release (however, framework was already released, so had to stay) So i guess the whole plasma_install_bundled_

Re: plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Nicolas Fella
On 29/07/2021 15:50, Alexander Lohnau wrote: Hi, in https://invent.kde.org/frameworks/kpackage/-/blob/master/KF5PackageMacros.cmake#L109  there is the a JSON file created. I think the problem is that this

Re: plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Alexander Lohnau
Hi, in https://invent.kde.org/frameworks/kpackage/-/blob/master/ KF5PackageMacros.cmake#L109[1] there is the a JSON file created. The initial discussion about this function was in https://phabricator.kde.org/D9197[2]. In https://phabricator.kde.org/D19383[3] the topic was also discussed, but wit

plasma_install_package vs plasma_install_bundled_package

2021-07-29 Thread Nicolas Fella
Hi, in https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMacros.cmake#L12 we recommend using plasma_install_bundled_package over plasma_install_package. However in practice we always use the latter, except for plasma-pa and plasma-nm. I stumbled across this because the b