On 29/07/2021 15:50, Alexander Lohnau wrote:
Hi, in https://invent.kde.org/frameworks/kpackage/-/blob/master/KF5PackageMacros.cmake#L109 <https://invent.kde.org/frameworks/kpackage/-/blob/master/KF5PackageMacros.cmake#L109> there is the a JSON file created.
I think the problem is that this file is installed next to the rcc bundle, but KPackage expects it inside the bundle, so loading the metadata from it doesn't work and it falls back to the .desktop file inside the bundle.
The initial discussion about this function was in https://phabricator.kde.org/D9197 <https://phabricator.kde.org/D9197 >. In https://phabricator.kde.org/D19383 <https://phabricator.kde.org/D19383> the topic was also discussed, but without getting a conclusion. There only being two users in all these years might be a sign that we don't really need it, especially since in the initial patch description it was stated that it is experimental :) Regards Alex On Thursday, July 29, 2021 2:29:01 PM CEST Nicolas Fella wrote: > Hi, > > in > https://invent.kde.org/frameworks/plasma-framework/-/blob/master/KF5PlasmaMa > cros.cmake#L12 we recommend using plasma_install_bundled_package over > plasma_install_package. > > However in practice we always use the latter, except for plasma-pa and > plasma-nm. > > I stumbled across this because the bundled version does not seem to > create a metadata.json from the metadata.desktop like the other macro > does. That means that the desktop file needs to be converted to json at > runtime which comes with a significant performance overhead when loading > a plasmoid. > > Now I'm wondering whether we should fix plasma_install_bundled_package > or port the two users away from it and abandon it. > > Thoughts? > > Cheers > > Nico
