D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Nathaniel Graham
ngraham added a comment. In D25100#592375 , @mak wrote: > @ngraham Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so that

D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Matthias Klumpp
mak added a comment. Did this have AppStream metadata before? Probably the distribution data still lists this as component, while the new file lists it as addon. The distro data is preferred, so that's why this shows up as app. You need your distro to ship this as update, or set `PreferLocal

D25100: Mark all wallpaper plugins as addons

2020-01-11 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Seems like this isn't the right way to solve the problem. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidre, davidedmundson, plasma-devel, LeGast00n, The-F

D25760: Unset X-Plasma-MainScript for wallpaper plugins

2019-12-05 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R114:e60c22ff27c6: Unset X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25760?vs=70949&id=7

D25760: Unset X-Plasma-MainScript for wallpaper plugins

2019-12-05 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The file path of the main script is hard-coded to ui/main.qml. REPOSITORY R114 Plasma Addons BRANCH u

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

2019-11-18 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R120:cf54a3e77395: Don't set X-Plasma-MainScript for wallpaper plugins (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25201?vs=694

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

2019-11-07 Thread Vlad Zahorodnii
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY The filename of the main script is hard-coded to ui/main.qml, so setting X-Plasma-MainScript is pointless.

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Aleix Pol Gonzalez
apol added a comment. > But the distro-provided version (openSUSE Tumbleweed) does not: Yes, this happens because distros don't take plasma-workspace as a dependency, but in your computer you do have plasma-workspace installed. REPOSITORY R114 Plasma Addons REVISION DETAIL https://p

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. In D25100#557494 , @apol wrote: > One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of the .plasma (which I'm pretty sure it doesn't make a difference, you can check by read

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Aleix Pol Gonzalez
apol added a comment. I just looked into it, the problem is that `plasma_packagestructure_wallpaper.so` is installed by plasma-workspace, which isn't a dependency of kdeplasma-addons. One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of the

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, it's the wrong fix. For reference, it's not about discover, it's about generating the appstream file properly. Will try to provide a patch next week. REPOSITORY R114 Pla

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread David Redondo
davidre added a comment. I don't know how Discover works but to me looks the wrong fix. Does every third party wallpaper then also need to have a name with plasma in it? In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as add-on and not having plasma in it's name.

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Nathaniel Graham
ngraham added a comment. Hmm so if this is the correct solution to the indicated problem, I guess we would need a kconf update script to change the IDs in `plasma-org.kde.plasma.desktop-appletsrc`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngr

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread David Edmundson
davidedmundson added a comment. What happens if a user has their setup to use potd or hunyango and we change this ID? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-O

D25100: Mark all wallpaper plugins as addons

2019-10-31 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, mak, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Heanau, Hunyango, and POTD wallpaper plugins still show up in Discover as apps because

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-05 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:230ac60a3195: Fix incorrect vertical spacing between main layout and individual wallpaper… (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-05 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop BRANCH beautiful-vertical-spacing (branched from master) REVISION DETAIL https://phabricator.kde.org/D20257 To: filipf, hein, mart, #plasma, ngraham, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zren

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-05 Thread Filip Fila
filipf added a comment. In D20257#443626 , @ngraham wrote: > Yep, looks like the correct solution to me. Nice find! One step closer to perfection! I think it's the correct solution as well. Maybe to elaborate better for the other rev

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yep, looks like the correct solution to me. Nice find! REPOSITORY R119 Plasma Desktop BRANCH beautiful-vertical-spacing (branched from master) REVISION DETAIL https://phabricator.k

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-04 Thread Filip Fila
filipf updated this revision to Diff 55443. filipf added a comment. apparently anchoring the stack view wasn't the only solution; settings spacing to 0 achieves the same result and doesn't spew out an "anchors in a layout" error REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE h

D20257: Fix incorrect vertical spacing between main layout and individual wallpaper plugins

2019-04-04 Thread Filip Fila
filipf added a comment. I know I'm not supposed to anchor items in a layout but this was the only solution I could find for now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20257 To: filipf, hein, mart, #plasma, ngraham Cc: plasma-devel, jraleigh, GB_2, r

D20257: Fix incorrent vertical spacing between main layout and individual wallpaper plugins

2019-04-04 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As elaborated in D19873 the vertical spacing between the master form layout and a specific wallp

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-26 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a3d4b38574fb: Support Kirigami.twinFormLayouts in individual wallpaper plugins (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19932?vs

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-25 Thread Filip Fila
content of the wallpaper plugins, but then we would get shifting text and option positions when changing wallpaper plugins. That wouldn't look good IMO. REPOSITORY R119 Plasma Desktop BRANCH support-twinLayouts (branched from master) REVISION DETAIL https://phabricator.kde.org/D199

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome. REPOSITORY R119 Plasma Desktop BRANCH support-twinLayouts (branched from master) REVISION DETAIL https://phabricator.kde.org/D19932 To: filipf, mart, #plasma, ngraham Cc:

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-21 Thread Filip Fila
filipf updated this revision to Diff 54485. filipf added a comment. remove line: twinFormLayouts: stack.item && stack.item.formLayout ? [stack.item.formLayout] : [] REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19932?vs=54459&id=54485 BRANCH sup

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-21 Thread Filip Fila
filipf added a comment. Second line results in a `stack` not defined error. I'm actually seeing it's enough to just have the id at line 82 and then in the wallpaper plugins do `twinFormLayouts: parentLayout`. REPOSITORY R119 Plasma Desktop REVISION DETA

D19932: Support Kirigami.twinFormLayouts in individual wallpaper plugins

2019-03-20 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch does the groundwork for indvidual wallpaper plugins to be able to use Kirigami FormLayout with twinFormLayouts, finally

D18343: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2

2019-01-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7e6d0c0b0eeb: [wallpapers/image] Port wallpaper plugins (mostly) to QQC2 (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18343?vs

D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham added a comment. Good call David! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18343 To: ngraham, #plasma Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mar

D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 49779. ngraham marked an inline comment as done. ngraham added a comment. Keep the QQC1 version of the ComboBox until we've fixed tps://bugs.kde.org/show_bug.cgi?id=403153 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread David Edmundson
davidedmundson added a comment. If you want to push everything except the combobox go for it. QQC allows us to mix, we should make use of that to do regression-free ports. INLINE COMMENTS > config.qml:90 > } > -QtControls.ComboBox { > +ComboBox { > id:

D18343: [Imagepackage] Port wallpaper plugins to QQC2

2019-01-17 Thread Nathaniel Graham
ngraham created this revision. ngraham added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 400549 FIXED-IN: 5.15.0 TEST PLAN On the lock screen KCM at 1.2x scale, before: Aft

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-10-09 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R119:347f43c42b70: Add "Get Wallpaper Plugins..." button to Config Desktop dialog (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-08-30 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. though only merge when we're ready. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma, davidedmundson Cc: mart, abetts

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-07-12 Thread David Edmundson
davidedmundson added a comment. Sorry for the delay Update: Spoke to kpackage maintainer. I'll add an anonymous DBus signal in kpackagetool and a PackageWatcher to monitor that. Then when I get that hooked up, the blocking problem will be solved. REPOSITORY R119 Plasma Desktop

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-05-16 Thread Marco Martin
mart added a comment. what's the status of this? when ready, should go in, together D12040 at the beginning of 3.14 vyvle REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: mart, abetts, davidedm

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-16 Thread Andres Betts
abetts added a comment. In D12041#247368 , @Zren wrote: > In D12041#247352 , @abetts wrote: > > > Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-16 Thread Chris Holland
Zren added a comment. In D12041#247352 , @abetts wrote: > Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-16 Thread Andres Betts
abetts added a comment. Why not save the room on the right of the KCM and instead blur the actual image in the list? Move the controls closer to that list item? The arrangement looks off the way it shows in the screenshots. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabrica

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-16 Thread David Edmundson
davidedmundson added a comment. Code that here is fine. As you say we need a tidy way to reload that list in order to have this mergable. I'll have a think. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: davidedmundson, ngraham

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland
Zren added a comment. I'm still unsure how to update the dropdown after you download a new plugin. I've moved the "open GHNS window" function in plasma-workspace to `components/shellprivate/wallpaperplugin`, but I've just noticed the dropdown is populated by `configDialog.wallpaperConfig

D12041: Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-15 Thread Chris Holland
Zren updated this revision to Diff 32246. Zren retitled this revision from "[WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog" to "Add "Get Wallpaper Plugins..." button to Config Desktop dialog". Zren edited the summary of this revisio

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-11 Thread David Edmundson
davidedmundson added a comment. Is this still a WIP or ready for review? Please update the title when it is ready. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12041 To: Zren, #plasma Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesl

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-08 Thread Chris Holland
Zren updated this revision to Diff 31700. Zren added a comment. Remove commented code. Add " New " to button label. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12041?vs=31652&id=31700 REVISION DETAIL https://phabricator.kde.org/D12041 AFFECT

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-08 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > Zren wrote in ConfigurationContainmentAppearance.qml:159 > "Get New Wallpaper" is capitalized. Are we using lowercase so the "Wallpaper > Plugins" stands out more? > > lowercase new vs uppercase New >

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-08 Thread Chris Holland
Zren added inline comments. INLINE COMMENTS > ngraham wrote in ConfigurationContainmentAppearance.qml:159 > It might be a bit wordy, but to be consistent with the form used everywhere > else, this should say, "Get new Wallpaper Plugins..." "Get New Wallpaper"

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-08 Thread Nathaniel Graham
> +iconName: "get-hot-new-stuff" > +text: i18nd("plasma_shell_org.kde.plasma.desktop", "Get > Wallpaper Plugins...") > +visible: KAuthorized.authorize("ghns") It might be a bit wordy, but to be consistent with the form used ever

D12041: [WIP] Add "Get Wallpaper Plugins..." button to Config Desktop dialog

2018-04-07 Thread Chris Holland
NS window from Patch 1: F5800268: 2018-04-08___02-02-49.png <https://phabricator.kde.org/F5800268> TEST PLAN 1. Install both patches 2. Configure Desktop > Get Wallpaper Plugins > Install something (eg: Ken Burns Effect) 3. Confirm it showed up in ~/.local/share/plasma/wall

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-24 Thread Commit Hook
org/r/106541/ > --- > > (Updated Sept. 23, 2012, 12:02 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch try to improve wheel scrolling behaviour when scrolling thumbnail >

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-24 Thread Commit Hook
org/r/106541/ > --- > > (Updated Sept. 23, 2012, 12:02 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch try to improve wheel scrolling behaviour when scrolling thumbnail > view i

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-23 Thread Commit Hook
org/r/106541/ > --- > > (Updated Sept. 23, 2012, 12:02 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch try to improve wheel scrolling behaviour when scrolling thumbnail >

Re: Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-23 Thread Aaron J. Seigo
. 23, 2012, 12:02 p.m.) > > > Review request for Plasma. > > > Description > --- > > This patch try to improve wheel scrolling behaviour when scrolling thumbnail > view inside 'virus' and 'pattern' wallpaper plugins. > To make it uniform lik

Review Request: improve wheel scrolling behaviour inside thumbnail view in virus and pattern wallpaper plugins

2012-09-23 Thread Reza Shah
wheel scrolling behaviour when scrolling thumbnail view inside 'virus' and 'pattern' wallpaper plugins. To make it uniform like 'image' wallpaper plugin Diffs - wallpapers/pattern/CMakeLists.txt b6771d4 wallpapers/pattern/config.ui 90fc7d1 wallpape

Re: Wallpaper plugins in default rendering mode

2010-07-30 Thread Aaron J. Seigo
On July 29, 2010, Will Stephenson wrote: > I think it would be simpler for wallpaper plugin writers if they > did not have to consider this case. it would be nicer, but most wallpapers only have one mode (so for those ones it's a non-issue) and automating it would mean having a way to mark which

Wallpaper plugins in default rendering mode

2010-07-29 Thread Will Stephenson
I've been looking at a bug in the Image plugin where dropping an image file on the desktop when the Image wallpaper plugin is not in use causes Image to start up in Slideshow mode. This is because Containment tries to set the default rendering mode using an empty string, whereas Image's logic fall

Re: Review Request: Make it possible to list installed wallpaper plugins in the plasmoid viewer

2009-10-26 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1973/#review2813 --- Ship it! one can already list wallpapers (including the modes in each

Review Request: Make it possible to list installed wallpaper plugins in the plasmoid viewer

2009-10-26 Thread Aleix Pol
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1973/ --- Review request for Plasma. Summary --- Adds the new option to the binary an

Re: Wallpaper plugins

2008-08-25 Thread Aaron J. Seigo
On Monday 25 August 2008, Petri Damstén wrote: > On Monday 25 August 2008 14:50:48 Aaron J. Seigo wrote: > > how about just not moving the applets to the new containment, and let > > them be created in Containment::restore; it would also solve this: > > There are some applets that will lose they hi

Re: Wallpaper plugins

2008-08-25 Thread Aaron J. Seigo
On Monday 25 August 2008, Petri Damstén wrote: > On Monday 25 August 2008 14:50:48 Aaron J. Seigo wrote: > > how about just not moving the applets to the new containment, and let > > them be created in Containment::restore; it would also solve this: > > My todo list for containment selection seems

Re: Wallpaper plugins

2008-08-25 Thread Petri Damstén
On Monday 25 August 2008 14:50:48 Aaron J. Seigo wrote: > how about just not moving the applets to the new containment, and let them > be created in Containment::restore; it would also solve this: My todo list for containment selection seems to be now empty. So are there any things left to do for

Re: Wallpaper plugins

2008-08-25 Thread Petri Damstén
On Monday 25 August 2008 14:50:48 Aaron J. Seigo wrote: > how about just not moving the applets to the new containment, and let them > be created in Containment::restore; it would also solve this: There are some applets that will lose they history (network monitor, etc) if created again, but on t

Re: Wallpaper plugins

2008-08-25 Thread Aaron J. Seigo
On Monday 25 August 2008, Petri Damstén wrote: > On Saturday 23 August 2008 18:51:12 Aaron J. Seigo wrote: > > KConfigGroup oldConfig = old->config(); > > oldConfig->copyTo(c->config()); > > > > this *should* bring over all the configurations: applets, wallpapers, > > everything. then we can call r

Re: Wallpaper plugins

2008-08-25 Thread Petri Damstén
On Saturday 23 August 2008 18:51:12 Aaron J. Seigo wrote: > KConfigGroup oldConfig = old->config(); > oldConfig->copyTo(c->config()); > > this *should* bring over all the configurations: applets, wallpapers, > everything. then we can call restore on the new containment with it's own > config object

Re: Wallpaper plugins

2008-08-24 Thread Petri Damstén
On Saturday 23 August 2008 18:51:12 Aaron J. Seigo wrote: > KConfigGroup oldConfig = old->config(); > oldConfig->copyTo(c->config()); > > this *should* bring over all the configurations: applets, wallpapers, > everything. then we can call restore on the new containment with it's own > config object

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 18:51:12 Aaron J. Seigo wrote: > so ... a new approach is called for as we're going to run into this same > issue (nested config groups) in a number of places. i think we should > probably just do something like this in swapContainment (completely > untested =): > > KConf

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > Containment calls restore for wallpaper like this d->wallpaper- > > >restore(KConfigGroup(&cfg, "Wallpaper"), mode); and wallpaper plugin tries > > to > > read it's config values from that but there is none (I think) since this is > the config grou

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 17:57:53 Aaron J. Seigo wrote: > On Saturday 23 August 2008, Petri Damstén wrote: > > If I have understood correctly restore calls setWallpaper which gives > > containments own config (not the old containments config used in restore) > > to wallpaper

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > If I have understood correctly restore calls setWallpaper which gives > containments own config (not the old containments config used in restore) > to wallpaper plugins. So should I fix setWallpaper so it can take the > KConfigGroup

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
lpaper which gives containments own config (not the old containments config used in restore) to wallpaper plugins. So should I fix setWallpaper so it can take the KConfigGroup from restore? > * we switch config objects: containmentConfig = c->config() > * new containment

Re: Wallpaper plugins

2008-08-23 Thread Aaron J. Seigo
On Saturday 23 August 2008, Petri Damstén wrote: > On Saturday 23 August 2008 01:05:38 Aaron J. Seigo wrote: > > > 2. Was wallpaper config save remove intentional? > > > > yes; i moved it to Containment::save > > But, doesn't that just save the wallpaper config to old containment. This > code was t

Re: Wallpaper plugins

2008-08-23 Thread Petri Damstén
On Saturday 23 August 2008 01:05:38 Aaron J. Seigo wrote: > > 2. Was wallpaper config save remove intentional? > > yes; i moved it to Containment::save But, doesn't that just save the wallpaper config to old containment. This code was there to copy wallpaper config to new containment. Petri s

Re: Wallpaper plugins

2008-08-22 Thread Aaron J. Seigo
On Thursday 21 August 2008, Petri Damstén wrote: > Hi, > > Fixes?/Questions (diff attached): > 1. Seems that setContainment(c) -> oldContainment->setScreen(otherScreen) > -> resets screen to -1. If setContainment is before restore it works better > but I'm not sure what other implications it might

Re: Wallpaper plugins

2008-08-21 Thread Petri Damstén
Hi, Fixes?/Questions (diff attached): 1. Seems that setContainment(c) -> oldContainment->setScreen(otherScreen) -> resets screen to -1. If setContainment is before restore it works better but I'm not sure what other implications it might have? 2. Was wallpaper config save remove intentional? 3.

Re: Wallpaper plugins

2008-08-20 Thread Aaron J. Seigo
On Wednesday 20 August 2008, Petri Damstén wrote: > > do you mean DataEngines connected to applets that are migrated from one > > containment to another? > > Yes, Digital clock remains empty until going to config dialog and pressing > ok and I also get messages like: ok, i think i see what's happe

Re: Wallpaper plugins

2008-08-20 Thread Aaron J. Seigo
On Wednesday 20 August 2008, Petri Damstén wrote: > On Wednesday 20 August 2008 12:08:36 Aaron J. Seigo wrote: > > is it that it gets the wrong geometry, or that the screen number isn't > > set? i'm guessing the latter. i'm suspicious of the > > c->restore(containmentConfig) line and the lack of a

Re: Wallpaper plugins

2008-08-20 Thread Petri Damstén
On Wednesday 20 August 2008 12:08:36 Aaron J. Seigo wrote: > is it that it gets the wrong geometry, or that the screen number isn't set? > i'm guessing the latter. i'm suspicious of the > c->restore(containmentConfig) line and the lack of a matching save. not all > the settings from the containment

Re: Wallpaper plugins

2008-08-20 Thread Aaron J. Seigo
per plugin (converted from > desktop containment). > - Configuration to color wallpaper plugin. > - Add Desktop configuration to desktop view (converted from desktop > containment). > - Desktop containment selection. > > Wallpaper plugins have been working pretty good on my machin

Wallpaper plugins

2008-08-20 Thread Petri Damstén
configuration to desktop view (converted from desktop containment). - Desktop containment selection. Wallpaper plugins have been working pretty good on my machine for some days. Desktop containment selection has more problems (Code in View::swapContainment). Some of the problems: - Containment gets