D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Never mind, @zzag discovered that I didn't have the `xorg-x11-server-sdk` package installed, so nothing to see here, and sorry for the noise! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: c

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. In D29514#665916 , @cblack wrote: > That's the source package location, not where you'd expect to find the headers for usage by other packages. You'd probably be looking for `/usr/include/xorg/xserver-properties.h`.

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

s have been disabled: > >* XorgServer, XServer header needed for touchpad KCM (X11 backend) > > -- The following OPTIONAL packages have not been found: > >* XorgServer, XServer header needed for touchpad KCM (X11 backend) > That's the sour

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

zzag added a comment. In D29514#665869 , @ngraham wrote: > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: What distro are you running? REPOSITORY R119 Plasm

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

14#665869>, @ngraham wrote: > > > > > Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: > > > > > > Where is synaptics-properties.h located on your system, if you even have

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

/xserver/include/xserver-properties.h`, and this doesn't seen to find it: > > > Where is synaptics-properties.h located on your system, if you even have been building touchpad kcm so far? It's in `/usr/include/xorg`. I must confess I've never actually been able to

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

s.h located on your system, if you even have been building touchpad kcm so far? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

ngraham added a comment. Hmm, on my system, the file is located at `/usr/src/xserver/include/xserver-properties.h`, and this doesn't seen to find it: -- The following features have been disabled: * XorgServer, XServer header needed for touchpad KCM (X11 ba

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29514 To: asturmlechner, #plasma, zzag Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D29514: Add FindXorgServer.cmake and use it for touchpad KCM

asturmlechner created this revision. asturmlechner added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. asturmlechner requested review of this revision. REVISION SUMMARY x11 backend of the touchpad KCM uses xserver-properties.h that is part of

D29040: Use colorful icon instead of monochrome icon for touchpad kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5cb382282de3: Use colorful icon instead of monochrome icon for touchpad kcm (authored by Guo Yunhe <i...@guoyunhe.me>). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29040: Use colorful icon instead of monochrome icon for touchpad kcm

https://phabricator.kde.org/D29040 AFFECTED FILES kcms/touchpad/kcm/kcm_touchpad.desktop To: guoyunhe Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fe4d395d792d: Touchpad kcm: On X11 hide scroll speed as it is not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28829?vs

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

meven created this revision. meven added reviewers: KWin, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 420079 TEST PLAN Tested locally REPOSITORY R119 Plasma Desktop BRANCH master

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7127724309a: [Touchpad KCM] Do not crash in case there is no touchpad (authored by beischer, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21884?vs=60026&id=60077

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. Doing it! REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampalo

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg accepted this revision. romangg added a comment. Yes, let's do that. Add a comment to the code that we fallback to evdev for now if no touchpad is connected and we want to show instead libinput in the future when the issues have been resolved. REPOSITORY R119 Plasma Desktop BRANCH

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham accepted this revision. ngraham added a comment. Shall we land this now and refine the behavior later? REPOSITORY R119 Plasma Desktop BRANCH bug-408325 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21884 To: beischer, ngraham, romangg, atulbi, #plasma, da

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. > 1. Controls not disabled > 2. "Two-finger-tap" radio buttons are missing their labels > 3. Middle-click label missing its radio buttons > > And then of course, unrelated to this patch or bug, is https://bugs.kde.org/show_bug.cgi?id=407464 Yes, thats

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

ngraham added a comment. In D21884#481680 , @romangg wrote: > What does not look right to you there? Are the controls greyed out? 1. Controls not disabled 2. "Two-finger-tap" radio buttons are missing their labels 3. Middle-click

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481572 , @beischer wrote: > That doesn't look right to me? Maybe because TouchpadConfigContainer::kcmInit() is a no-op (first because the mode is Unset, so neither of the two if branches triggers, but even if t

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. In D21884#481568 , @romangg wrote: > Ok, that would be even better. Only drawback is then that it shows the "wrong" interface in case libinput is used until a touchpad is plugged, but that's such an uncommon case that I

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. In D21884#481567 , @beischer wrote: > Roman, with this patch the box with 'No touchpad found' is shown under X11, too: > > F6907948: no_touchpad.png > > Since I'm not the aut

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

beischer added a comment. Roman, with this patch the box with 'No touchpad found' is shown under X11, too: F6907948: no_touchpad.png Since I'm not the author of the code my intention was to fix the bug with as little side effects as possible. I

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

romangg added a comment. On Wayland it shows a message that no touchpad is connected. Would it be possible on X to determine if a to-be-connected touchpad would use libinput or Xlib (although the use case is pretty rare of a detechable touchpad)? REPOSITORY R119 Plasma Desktop BRANCH bu

D21884: [Touchpad KCM] Do not crash in case there is no touchpad

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Heh, so we show a backend that will do nothing instead? That doesn't sound like the right long term approach. Will do for backporting into stable. REPOSITORY R119 Pl

D21884: [Touchpad KCM] Do not crash in case there is no touchpad.

beischer created this revision. beischer added reviewers: ngraham, romangg, atulbi, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. beischer requested review of this revision. REVISION SUMMARY Fixes bug #4083250. REPOSITORY R119 Plasma Desktop BRANCH bug-40

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

This revision was automatically updated to reflect the committed changes. Closed by commit R119:999b619bc5c8: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a… (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D21439: [Touchpad KCM] Revoke touchpad enabled/disabled notification before sending a new one

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 387590 FIXED-IN: 5.16.0 TEST PLAN Enabled automatic touchpad disabling when plugging in

D21278: [Touchpad KCM] Fix kded crashing at startup

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup (authored by atulbi). REPOSITORY R119 Plas

D21278: [Touchpad KCM] Fix kded crashing at startup

romangg accepted this revision. romangg added a comment. Feedback positive in bug report. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21278 To: atulbi, romangg, davidedmundson Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himc

D21278: [Touchpad KCM] Fix kded crashing at startup

romangg added a comment. Codewise looks fine. Good adaption in comparison to first revision! Question remains if we want to further disconnect/deactivate the applet functionality in case libinput is used. We don't need to watch the keyboard presses at all. Same holds for the Wayland case, wh

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi updated this revision to Diff 58319. atulbi added a comment. - Now we have separate m_touchpadOffAtom for synaptics and Libinput. On Libinput, used m_enabled prop. - setTouchpadOff will be ignored on X Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://ph

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466804 , @romangg wrote: > > by kded on key press other than Kded Keyboard shortcuts > > Do you mean it's sent on shortcut or not? Just wondering why I couldn't replicate the issue in my testing. kded

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi added a comment. In D21278#466801 , @davidedmundson wrote: > > m_connection seems to be having null or 0x0 value. > > Which means we're calling XcbAtom::atom after being constructed from the default constructor not the proper one. >

D21278: [Touchpad KCM] Fix kded crashing at startup

romangg added a comment. I believe we don't call the `XcbAtom::intern` function in the X libinput backend, what we do in the evdev/synaptics constructor part. Question is if we just don't want to not send the relevant call on keypress after all in X libinput. Because libinput does the disabl

D21278: [Touchpad KCM] Fix kded crashing at startup

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > m_connection seems to be having null or 0x0 value. Which means we're calling XcbAtom::atom after being constructed from the default constructor not the prope

D21278: [Touchpad KCM] Fix kded crashing at startup

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY When XcbAtom::atom() is called (by kded on key press other than Kded Keyboard shortcuts), m_connection seems to be having null or 0x0

D21269: [Touchpad KCM] Fixed loading of wrong qml file

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml file (authored by atulbi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21269?vs=58248&id=58260#toc REPOSITORY R119 Plasma Des

D21269: [Touchpad KCM] Fixed loading of wrong qml file

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Good find. Also backport to beta branch. REPOSITORY R119 Plasma Desktop BRANCH touchpad-mouse REVISION DETAIL https://phabricator.kde.org/D21269 To: atulbi, romangg, ngraham Cc: p

D21269: [Touchpad KCM] Fixed loading of wrong qml file

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY On system settings, If Mouse KCM is opened first, then touchpad KCM loads the same Mouse QML file (qrc::/libinput/main.qml) instead

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi added a comment. Thank you so much for fixing it. Wanted it to on beta. INLINE COMMENTS > romangg wrote in libinputtouchpad.cpp:426 > Why this write back? What's configProps. Yeah realized later that there is no need to write config here. So no need for configProps. Should I open a

D21228: [Touchpad KCM] Load previous setting on reboot

This revision was automatically updated to reflect the committed changes. romangg marked an inline comment as done. Closed by commit R119:5afc24db67ed: [Touchpad KCM] Load previous setting on reboot (authored by atulbi, committed by romangg). CHANGED PRIOR TO COMMIT https://phabricator.kde.org

D21228: [Touchpad KCM] Load previous setting on reboot

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > touchpadconfigcontainer.cpp:59 > +backend->applyConfig(); > +} > +else if (backend->getMode() == TouchpadInputBackendMode::XSynaptics) {

D21228: [Touchpad KCM] Load previous setting on reboot

romangg updated this revision to Diff 58164. romangg added a comment. - Fix loading, code style, shared cfg ptr REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21228?vs=58131&id=58164 BRANCH arcpatch-D21228 REVISION DETAIL https://phabricator.kd

D21228: [Touchpad KCM] Load previous setting on reboot

fvogt added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:34 > > +const QSet configProps = { > +QStringLiteral("enabled"), `static`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21228 To: atulbi, ngraham, romangg, davidedmundson Cc: fvogt, da

D21228: [Touchpad KCM] Load previous setting on reboot

romangg added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:56 > +QStringLiteral("clickMethodClickfinger") > +}; > + In best case these should be in some way shared with libinputProperties array to minimize code duplication. But as long as these names are the same as in libinputP

D21228: [Touchpad KCM] Load previous setting on reboot

romangg added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:216 > } > +KSharedConfigPtr configPtr = > KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc")); > +m_config = configPtr.data(); The name of the config file should be something similar to the other one a

D21228: [Touchpad KCM] Load previous setting on reboot

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > libinputtouchpad.cpp:217 > +KSharedConfigPtr configPtr = > KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc")); > +m_config

D21228: [Touchpad KCM] Load previous setting on reboot

nicolasfella added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:415 > + > +if (replyValue!=savedValue) { > +replyValue = savedValue; Coding style: Space around != REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21228 To: atulbi, ngraham,

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

fvogt added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being i

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier Previous setting were not loaded on reboot instead default settings were loaded. So, added config file for saving the setti

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being implemented yet: $ cat /etc/X11/xorg.conf.d/99-libinput.conf Section "In

D21220: [Touchpad KCM] Fix libinput-less build and warnings

zzag added inline comments. INLINE COMMENTS > libinputcommon.h:28 > template > -T valueLoaderPart(QVariant const &reply) { Q_UNUSED(reply); return T(); } > +inline T valueLoaderPart(QVariant const &reply) { Q_UNUSED(reply); return > T(); } > Just a note for the future: you don't have to defi

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. > In D20186#465395 , @romangg wrote: > >> I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? >> >> EDIT: No, they are not. In X11 + evdev th

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#465502 , @atulbi wrote: > In D20186#465361 , @ngraham wrote: > > > @atulbi This has caused a failure in the CI: > > [...] > > > > Looks like we need to make

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465361 , @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41 /home/jenk

D21220: [Touchpad KCM] Fix libinput-less build and warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b1c894effa0: [Touchpad KCM] Fix libinput-less build and warnings (authored by romangg). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21220?vs=58100&am

D21220: [Touchpad KCM] Fix libinput-less build and warnings

romangg updated this revision to Diff 58100. romangg added a comment. Also include libinput header only when compiling with X.Org libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21220?vs=58098&id=58100 BRANCH touchpadLibinputFixes REVISI

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#465361 , @ngraham wrote: > @atulbi This has caused a failure in the CI: > > https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console > > 09:12:41 /home/jen

D21220: [Touchpad KCM] Fix libinput-less build and warnings

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY If the X.Org libinput dev packages are not found, do not build the X11 libinput backend. This wa

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a subscriber: fvogt. ngraham added a comment. @atulbi This has caused a failure in the CI: https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console 09:12:41 /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ce84d6ab4bab: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is… (authored by atulbi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465278 , @ngraham wrote: > Are you ready for me to land this? Yeah \o/ I'll take that for the next patch. REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D20186 REVISION DETAIL https://phabricato

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham accepted this revision. ngraham added a comment. Are you ready for me to land this? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar, plas

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58083. atulbi added a comment. Set visible to false, until accel profiles are not supported. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=58082&id=58083 BRANCH arcpatch-D20186 REVISION DETAIL http

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#465267 , @atulbi wrote: > Regarding acceleration profile, maybe we should set visible to false for now. +1, let's do that in this patch > If no touchpad is connected, we could also show a large icon

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 58082. atulbi added a comment. Finally no more greyed settings there \o/ Work I've planned for future releases : - Adding support to disable horizontal scrolling on wayland. - Provide settings to Disable touchpad on external mouse. Regarding

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

tient in the review process. Indeed. Party time for sure!!! Also @atulbi if you don't already have commit access you should seriously consider applying--especially given that you're now the maintainer of the touchpad KCM. See https://techbase.kde.org/Contribute/Get_a_Contributor_Accoun

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ad is connected and one opens the touchpad KCM. Normally all controls should be greyed out. But at least on Wayland they are not but instead some of them are not shown. But for now let's celebrate finally shipping a fitting libinput KCM on X as well! Great job Atul! Thank you for your hard wo

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57933. atulbi added a comment. - lmr mapping working now REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57923&id=57933 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 AFFE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57923. atulbi added a comment. - Added Copyright notice - Corrected asterisk placement REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57521&id=57923 BRANCH arcpatch-D20186 REVISION DETAIL https://

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added inline comments. INLINE COMMENTS > romangg wrote in libinputtouchpad.h:57 > Why is there the negation? Put the Enabled-related function in the parent > class. X provides property for the disabled, while Wayland provides property for enabled. REPOSITORY R119 Plasma Desktop REVI

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Looks really nice. I have yet to try it out, but following a code review. In general it is good practice to make class member variables private and have protected getters/se

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. I'm afraid I don't think I have the technical chops to adequately review this, but hopefully @romangg does! :) Or any of the other #plasma people. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#462883 , @GB_2 wrote: > Ping Hey... Have you tried this patch ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasm

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57521. atulbi added a comment. - Remove CMakeLists.txt.user REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57520&id=57521 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 A

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57520. atulbi added a comment. - Changes Made : 1. Added abstract class LibinputCommon. 2. All the Q_PROPERTY are in LibinputCommon. 3. Added Disable Horizontal Support on X11 on Libinput. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57519. atulbi added a comment. - Removed last commit REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=57508&id=57519 BRANCH arcpatch-D20186 REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 57508. atulbi added a comment. - Added new abstract class LibinputCommon - Add overriding destructor - Added support for disable horizontal scrolling on Libinput On X11. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55532&id=57508 B

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Wonderful! I'll stop bugging you now. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: jriddell, knambiar, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, leslie

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#458259 , @ngraham wrote: > @atulbi were you able to get in touch with @romangg? Can I help in any way? > > The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi were you able to get in touch with @romangg? Can I help in any way? The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules/Plasma_5) and it would really nice to finally have full Libinput support in our KCM i

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#454584 , @atulbi wrote: > In D20186#454420 , @ngraham wrote: > > > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#454420 , @ngraham wrote: > @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. Totally!! I'm working on it... Currently faci

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. @atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #p

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#31 , @atulbi wrote: > In D20186#443596 , @romangg wrote: > > > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443596 , @romangg wrote: > Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55532. atulbi added a comment. - Resolved issues REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55277&id=55532 BRANCH X11Libinput REVISION DETAIL https://phabricator.kde.org/D20186 AFFECTED FILES

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi the default assignee for bugs to the Touchpad-KCM product. > > @atulbi Congratulations, you’re now the maintainer of Touchpad KCM. In certain countries, there’s something called “inheritance tax” and you just inherited a few dozen bugs. Don’t despair, many of them should be fixed

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#443554 <https://phabricator.kde.org/D20186#443554>, @ngraham wrote: > In D20186#443262 <https://phabricator.kde.org/D20186#443262>, @knambiar wrote: > > > >> I happen to be the ‘accidental’ maintainer of the Touchpad K

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product. @atulbi Congratulatio

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such th

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. In D20186#443262 <https://phabricator.kde.org/D20186#443262>, @knambiar wrote: > >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D > >

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a subscriber: jriddell. knambiar added a comment. >> I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D > > Hey, I would be happy to take that responsibility.

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#442088 <https://phabricator.kde.org/D20186#442088>, @knambiar wrote: > > Got to Know a lot about how X works with input handling. XD > > I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to han

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi updated this revision to Diff 55277. atulbi added a comment. - Code Cleanup and resolved unexpected behaviour REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20186?vs=55251&id=55277 BRANCH X11Libinput REVISION DETAIL https://phabricator.k

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

knambiar added a comment. > Got to Know a lot about how X works with input handling. XD I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D REPOSITORY R119 Plasma Desktop REVISION DET

  1   2   3   >