romangg added a comment.
In D20186#465502 <https://phabricator.kde.org/D20186#465502>, @atulbi wrote: > In D20186#465361 <https://phabricator.kde.org/D20186#465361>, @ngraham wrote: > > > @atulbi This has caused a failure in the CI: > > [...] > > > > Looks like we need to make the libinput xorg dev package a mandatory dep (boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I know it's short notice but we branch in two days; do you think you could fix this? Thanks! > > > Whoops... > If it's just because of "libinput-properties.h", then we could replace all macros with their property name, then there is no need for libinput-properties.h . This was already fixed in 8b1c894ef <https://phabricator.kde.org/R119:8b1c894effa08a530ec64a3b4563cfea3765b7de>. What still needs to be done is: In D20186#465395 <https://phabricator.kde.org/D20186#465395>, @romangg wrote: > I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? > > EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. We need to: > > 1. add config file write and load functions to the X11-libinput backend > 2. add a hook to kcm_init such that the load function is called on startup. > > @atulbi: Do you have time to try this tomorrow? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20186 To: atulbi, ngraham, romangg, davidedmundson, #plasma Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
