D19011: Thunderbolt KCM and KDED module

ngraham added a subscriber: jriddell. ngraham added a comment. I guess you'll have to wait for 5.17 for that, unless @jriddell wants to oblige. :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: jriddell, pino, zzag, GB_2,

D19011: Thunderbolt KCM and KDED module

asturmlechner added a comment. In D19011#480868 , @ngraham wrote: > and we should lobby distros to ship with the new repo/package. Provide a tarball and I'll gladly turn our git master ebuild into a release ebuild. ;) REPOSITORY R119 P

D19011: Thunderbolt KCM and KDED module

dvratil abandoned this revision. dvratil added a comment. The code has been moved to a standalone plasma-thunderbolt repository, passed through kde-review and will be included in Plasmas 5.17 release. Thanks everyone for your feedback and comments! REPOSITORY R119 Plasma Desktop REVIS

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Ah OK, I hadn't realized it got moved there yet. I guess this revision can be abandoned then, and we should lobby distros to ship with the new repo/package. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #pla

D19011: Thunderbolt KCM and KDED module

pino added a comment. In D19011#480594 , @ngraham wrote: > Plasma 5.16 has been released and master is wide open for new features. Can we get this landed in some capacity soon? It would be great to have more testing time. There is alread

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Plasma 5.16 has been released and master is wide open for new features. Can we get this landed in some capacity soon? It would be great to have more testing time. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vd

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. `plasma-thunderbolt` sounds fine to me FWIW. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, brouli

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. @broulik I asked on plasma-devel where to put this and got no definitive answer, so I put it here. Separate repo is fine with me, too. What name for the repo would you prefer? plasma-thunderbolt? I already have kcm_bolt scratch repo, so I can just "backport" the chan

D19011: Thunderbolt KCM and KDED module

broulik added a comment. I was wondering, since this thing has like a lib and kded and what not, wouldn't it make sense to have that be a separate module and repository rather than in plasma-desktop "just because" all kcms are in there? For the lack of Thunderbolt devices I have only tri

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. I say let's get this in for 5.16. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb,

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 57147. dvratil added a comment. - Update the icon - Rebase on current master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=54625&id=57147 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricat

D19011: Thunderbolt KCM and KDED module

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. New icon just landed in D20672 . The name is `preferences-desktop-thunderbolt`. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnoc

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Submit it in a patch to breeze-icons! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: zzag, GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, o

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. It might be not very stylish but just to make the whole thing work... F6780264: preferences-desktop-thunderbolt.svg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #pla

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#450414 , @dvratil wrote: > I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about ico

D19011: Thunderbolt KCM and KDED module

zzag added inline comments. INLINE COMMENTS > kded_bolt.h:34 > +class KNotification; > +namespace Bolt { > +class Device; Coding style nitpick: > Function implementations, class, struct and namespace declarations always > have the opening brace on the start of a line. > dbushelper.cpp:35 > +

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. I realized we still need an icon for Thunderbolt (and thus for this KCM) - @abetts, @andreask, @trickyricky26, @ndavis - could one of you help me out, please? I have no clue about icons... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.or

D19011: Thunderbolt KCM and KDED module

GB_2 added a comment. Looks ok to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: GB_2, knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, pla

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 54625. dvratil added a comment. Remove 'Help', 'Default' and 'Apply' buttons as they serve no purpose here, there's no help at the moment, there's no default state to revert to and the changes to devices are applied immediately. REPOSITORY R119 Plasm

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. What should happen when the "Help" button at the bottom of KCM page is pressed? Thanks in advance for your answer. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, an

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Ping, VDG folks are OK with this, how about Plasma :)? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik,

D19011: Thunderbolt KCM and KDED module

ngraham accepted this revision as: VDG. ngraham added a comment. UI looks good to me now! Nice job. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabian

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 53323. dvratil added a comment. - Wording: Trust this Device/Revoke Trust button labels REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52775&id=53323 BRANCH arcpatch-D19011 REVISION DETAIL https://

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Didn't like my latest string suggestions? Trust this Device / Revoke Trust REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: knambiar, bernieinnocenti, andreask, ndavis, trickyricky26, abetts, f

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52775. dvratil added a comment. - Use colors in device status indicators REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52593&id=52775 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricator.kde

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#420361 , @abetts wrote: > Can the text to the right of the list, "Trusted" be a different color and maybe a smaller font? When using the same font, color and size as the device name, it seems that they are the

D19011: Thunderbolt KCM and KDED module

abetts added a comment. Can the text to the right of the list, "Trusted" be a different color and maybe a smaller font? When using the same font, color and size as the device name, it seems that they are the same thing. One is device name and the other is device status. I am just wondering i

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52593. dvratil added a comment. - Wording: improved trust button labels, thanks for suggestions, Nate. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52568&id=52593 BRANCH arcpatch-D19011 REVISION DE

D19011: Thunderbolt KCM and KDED module

ngraham added inline comments. INLINE COMMENTS > DeviceView.qml:133 > +id: storeBtn > +text: i18n("Set as Trusted") > +visible: device && device.status == > Bolt.Bolt.Status.Authorized && device.stored == false "Trust this Device"? > DeviceView.q

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52568. dvratil added a comment. - Wording: replaced Stored with Trusted - Layout: centered all controls on device view page REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52255&id=52568 BRANCH arcpa

D19011: Thunderbolt KCM and KDED module

knambiar added a comment. > How about "Trusted" for remembered devices that are authorized, and "Prohibited" for remembered devices that are not authorized? > > "Remembered" would work only if it's clear what's being remembered (i.e. the settings). Maybe it could say "Settings remembered

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#417634 , @dvratil wrote: > "Stored" is a term for a remembered device. When you authorize a device, the authorization is "stored", or remembered, so you don't have to authorize it again next time. Maybe "Rememb

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. "Stored" is a term for a remembered device. When you authorize a device, the authorization is "stored", or remembered, so you don't have to authorize it again next time. Maybe "Remember" would be a better term, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. Thanks, much better! Just a few more UI nitpicks. And one more thing: What does "Stored" mean in this context? As a non-Thunderbolt expert, I don't know what this means, and I suspect most users wouln't, either. INLINE COMMENTS > DeviceList.qml:41 > +id:

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52255. dvratil added a comment. - fix look of the device list REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=51737&id=52255 BRANCH arcpatch-D19011 REVISION DETAIL https://phabricator.kde.org/D19011

D19011: Thunderbolt KCM and KDED module

ngraham added subscribers: trickyricky26, ndavis, andreask. ngraham added a comment. In D19011#415228 , @dvratil wrote: > Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbol

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. Thanks for the feedback, I'll look into it asap. In the meantime, could I ask the VDG to create a Breeze icon for Thunderbolt? @abetts, maybe? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19011 To: dvratil, #vdg, #plasma Cc: abetts

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#412803 , @abetts wrote: > I believe the list of devices should be in a white box. There should also be a couple of controls at the bottom right of the box containing the devices. @ngraham Is that right? @fabian

D19011: Thunderbolt KCM and KDED module

abetts added subscribers: ngraham, fabianr, abetts. abetts added a comment. I believe the list of devices should be in a white box. There should also be a couple of controls at the bottom right of the box containing the devices. @ngraham Is that right? @fabianr ? REPOSITORY R119 Plasma Des

D19011: Thunderbolt KCM and KDED module

dvratil added inline comments. INLINE COMMENTS > broulik wrote in DeviceList.qml:11 > You might want to be using a `ScrollViewKCM` and put the enable checkbox in > the `header` and the `ListView` in `view`, see for instance KWin's virtual > desktop KCM Hmm, but then I couldn't push the device

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 51737. dvratil marked 9 inline comments as done. dvratil added a comment. - Fixed typos - Unified license - Addresses comments from kbroulik REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=51693&id=51

D19011: Thunderbolt KCM and KDED module

broulik added inline comments. INLINE COMMENTS > DeviceList.qml:11 > + > +Kirigami.Page { > +id: page You might want to be using a `ScrollViewKCM` and put the enable checkbox in the `header` and the `ListView` in `view`, see for instance KWin's virtual desktop KCM > DeviceList.qml:29 > +

D19011: Thunderbolt KCM and KDED module

ognarb added inline comments. INLINE COMMENTS > fakeserver.h:1 > +#ifndef FAKESERVER_H > +#define FAKESERVER_H You forgot to add a GPL license header for this file. Same for: - autotests/bolt/fakeserver/fakeserver.cpp - autotests/bolt/kded/kdedtest.cpp - autotests/bolt/lib/managertest.cpp - aut

D19011: Thunderbolt KCM and KDED module

yurchor added a comment. Thanks in advance for fixing these minor typos. INLINE COMMENTS > DeviceView.qml:122 > +function() { > +console.log("Device " + device.uid + " enrolled > successfuly"); > +}, Typo: successfu

D19011: Thunderbolt KCM and KDED module

dvratil created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The KCM allows user to authorize and store (or forget) the authorization of Thunderbolt 3 devices. This is done by communicating w

Re: Thunderbolt KCM

On Thursday, February 7, 2019 6:22:59 AM CET Rajeesh K V wrote: > First, is this something you Plasma folks would like to have in regular > > > Plasma > > releases, or should I just make it an extragear project? If you think it > > makes > > sense to include it in Plasma, should it go to plasma-wo

Re: Thunderbolt KCM

First, is this something you Plasma folks would like to have in regular > Plasma > releases, or should I just make it an extragear project? If you think it > makes > sense to include it in Plasma, should it go to plasma-workspace, or should > it > be a standalone thing, like plasma-nm? It does have

Thunderbolt KCM

Hi all, last year I got a new Dell laptop at work with a docking station connected via the Thunderbolt thingy and I found out that there's a DBus daemon for Linux that allows users to authorize TB devices...long story short I somehow happened to have created a KCM to manage TB devices and a KDE