dvratil added inline comments.

INLINE COMMENTS

> broulik wrote in DeviceList.qml:11
> You might want to be using a `ScrollViewKCM` and put the enable checkbox in 
> the `header` and the `ListView` in `view`, see for instance KWin's virtual 
> desktop KCM

Hmm, but then I couldn't push the device view page on the stack, because there 
would be no PageRow, right?

> broulik wrote in device.h:45
> Does bolt not notify property changes on dbus? Not a huge fan of this Timer 
> refresh hack

Unfortunately not, the DBus interface is a bit weird and the implementation 
even weirder.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil
Cc: broulik, ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Reply via email to