Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99390 --- for reference, look at what the recent commit b2d91a39740b00

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread Marco Martin
> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote: > > shell/scripting/panel.cpp, line 189 > > > > > > this can't rely on the order of qGuiApp->screens, but should use > > screenpool in shellcorona, it's the on

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99342 --- shell/scripting/panel.cpp (line 182)

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-20 Thread Kamil Sołtysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/ --- (Updated Sept. 20, 2016, 2:25 p.m.) Review request for Plasma. Changes

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-20 Thread Kamil Sołtysik
> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote: > > shell/scripting/panel.cpp, line 189 > > > > > > this can't rely on the order of qGuiApp->screens, but should use > > screenpool in shellcorona, it's the on

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Marco Martin
> On Sept. 19, 2016, 9:43 p.m., David Edmundson wrote: > > The problem with this patch (which highlights a mix we have in plasma in > > general) is that it's mixing whether the screen is managed by the view or > > managed by the containment. > > With this you're overriding the screen() method f

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99285 --- shell/scripting/panel.cpp (line 189)

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99284 --- The problem with this patch (which highlights a mix we have i

Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-19 Thread Kamil Sołtysik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/ --- Review request for Plasma. Bugs: https://bugs.kde.org/show_bug.cgi?id=363