----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99342 -----------------------------------------------------------
shell/scripting/panel.cpp (line 182) <https://git.reviewboard.kde.org/r/128950/#comment66881> that's still going to crash if used in an initial setup plasma script. - David Edmundson On Sept. 20, 2016, 2:25 p.m., Kamil Sołtysik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128950/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 2:25 p.m.) > > > Review request for Plasma. > > > Bugs: https://bugs.kde.org/show_bug.cgi?id=363592 > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592 > > > Repository: plasma-workspace > > > Description > ------- > > As stated in doc here: > https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels > Panels should allow to be placed on selected screen by setting value of > Panel::screen property. While looking at code I found out that this property > is read-only in code. Patch changes that. > > > Diffs > ----- > > shell/scripting/panel.h 0d70784 > shell/scripting/panel.cpp b9383df > > Diff: https://git.reviewboard.kde.org/r/128950/diff/ > > > Testing > ------- > > Panel's position can now be changed by setting the property. Setting invalid > value causes no response. > > > File Attachments > ---------------- > > plasma-workspace-2.patch > > https://git.reviewboard.kde.org/media/uploaded/files/2016/09/20/bc1df578-8758-48e4-b2b2-a53792c803f8__plasma-workspace-2.patch > > > Thanks, > > Kamil Sołtysik > >
