Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/ --- (Updated Sept. 4, 2016, 11:51 p.m.) Status -- This change has been m

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread David Edmundson
> On Sept. 2, 2016, 6:17 p.m., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes". > > Wolfgang Bauer wrote: > I agree. > This change will still make it use ~/.local/share/sddm/themes/ if it > should

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-04 Thread Antonio Rojas
> On Sept. 2, 2016, 6:17 p.m., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes". > > Wolfgang Bauer wrote: > I agree. > This change will still make it use ~/.local/share/sddm/themes/ if it > should

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-03 Thread Wolfgang Bauer
> On Sept. 2, 2016, 8:17 nachm., Fabian Vogt wrote: > > IMO you should use the same method as sddm, which is hardcoded at configure > > time: "@DATA_INSTALL_DIR@/themes". I agree. This change will still make it use ~/.local/share/sddm/themes/ if it should exist for some reason, and ignore /usr

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-03 Thread Antonio Rojas
> On Sept. 3, 2016, 9:48 a.m., David Edmundson wrote: > > Ship It! > > David Edmundson wrote: > do you have commit access? Not yet, I just applied for a dev account - Antonio --- This is an automatically generated e-mail. To reply,

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-03 Thread David Edmundson
> On Sept. 3, 2016, 9:48 a.m., David Edmundson wrote: > > Ship It! do you have commit access? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/#review98840

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/#review98840 --- Ship it! Ship It! - David Edmundson On Sept. 2, 2016, 5

Re: Review Request 128815: Fix themes list with SDDM 0.14

2016-09-02 Thread Fabian Vogt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/#review98833 --- IMO you should use the same method as sddm, which is hardcode

Review Request 128815: Fix themes list with SDDM 0.14

2016-09-02 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128815/ --- Review request for Plasma and David Edmundson. Repository: sddm-kcm Des