Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88649 --- src/plasma/svg.cpp (line 581)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 1:27 p.m.) Status -- This change has been ma

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread David Edmundson
> On Nov. 20, 2015, 12:35 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 590 > > > > > > we may as well remove this method then? Edit. obviously we can't. Ignore me. - David --

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88643 --- Ship it! src/plasma/svg.cpp (line 590)

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 12:19 p.m.) Review request for KDE Frameworks and

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
> On Nov. 19, 2015, 5:38 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 47 > > > > > > An SVG with colours will have a Theme object (via > > SvgPrivate::cacheAndColorsTheme()) > > > > ThemePri

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- (Updated Nov. 20, 2015, 11:18 a.m.) Review request for KDE Frameworks and

Re: Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88619 --- src/declarativeimports/core/units.cpp (line 41)

Review Request 126113: make event filters static to decrease installed filters on qApp

2015-11-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/ --- Review request for KDE Frameworks and Plasma. Bugs: 351923 http://bug