----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126113/#review88619 -----------------------------------------------------------
src/declarativeimports/core/units.cpp (line 41) <https://git.reviewboard.kde.org/r/126113/#comment60747> Why not just make this the static object...rather than having the SharedAppFilterStatic class which will have one instance of this? src/declarativeimports/core/units.cpp (line 53) <https://git.reviewboard.kde.org/r/126113/#comment60749> You only want ApplicationFontChange. qapplication.cpp:1671 QEvent e(QEvent::ApplicationFontChange); QApplication::sendEvent(QApplication::instance(), &e); src/plasma/svg.cpp (line 47) <https://git.reviewboard.kde.org/r/126113/#comment60748> An SVG with colours will have a Theme object (via SvgPrivate::cacheAndColorsTheme()) ThemePrivate already has an (effecively shared) event filter on colours changing, can we use directly? - David Edmundson On Nov. 19, 2015, 12:08 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126113/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2015, 12:08 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Bugs: 351923 > http://bugs.kde.org/show_bug.cgi?id=351923 > > > Repository: plasma-framework > > > Description > ------- > > since seems there are so many event filters installed on the QApplication > installed that may give performance issues, try to use separate, singleton > watchers for them to decrease the amount of eventfilters called > > > Diffs > ----- > > src/declarativeimports/core/units.h fa2256e > src/declarativeimports/core/units.cpp 4e2adae > src/plasma/private/svg_p.h 597465e > src/plasma/svg.cpp bcceaf7 > > Diff: https://git.reviewboard.kde.org/r/126113/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
