Re: Review Request 125825: Add guards for Xlib code

2015-10-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/ --- (Updated Oct. 27, 2015, 10 a.m.) Status -- This change has been mark

Re: Review Request 125825: Add guards for Xlib code

2015-10-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/#review87497 --- Ship it! Ship It! - David Edmundson On Oct. 27, 2015, 9:25

Re: Review Request 125825: Add guards for Xlib code

2015-10-27 Thread Martin Gräßlin
> On Oct. 27, 2015, 10:32 a.m., David Edmundson wrote: > > libkhotkeysprivate/windows_handler.h, line 67 > > > > > > why store this as a member var isntead of just running > > > > isPlatformX11 each time.

Re: Review Request 125825: Add guards for Xlib code

2015-10-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/#review87494 --- libkhotkeysprivate/windows_handler.h (line 67)

Review Request 125825: Add guards for Xlib code

2015-10-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125825/ --- Review request for Plasma and David Edmundson. Repository: khotkeys Des