> On Oct. 27, 2015, 10:32 a.m., David Edmundson wrote:
> > libkhotkeysprivate/windows_handler.h, line 67
> > <https://git.reviewboard.kde.org/r/125825/diff/1/?file=412978#file412978line67>
> >
> > why store this as a member var isntead of just running
> >
> > isPlatformX11 each time. It can't be an expensive function?
> It can't be an expensive function?
Judge for yourself:
bool QX11Info::isPlatformX11()
{
return QGuiApplication::platformName() == QLatin1String("xcb");
}
I consider that a needless string comparison thus I use the variable.
> On Oct. 27, 2015, 10:32 a.m., David Edmundson wrote:
> > libkhotkeysprivate/windows_handler.cpp, line 100
> > <https://git.reviewboard.kde.org/r/125825/diff/1/?file=412979#file412979line100>
> >
> > or port to KWindowInfo ?
I don't want to touch unrelated code and have no real way to test that.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125825/#review87494
-----------------------------------------------------------
On Oct. 27, 2015, 10:25 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125825/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:25 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: khotkeys
>
>
> Description
> -------
>
> KHotkeys currently crashes kded on platform Wayland: let's add some
> guards.
>
>
> Diffs
> -----
>
> libkhotkeysprivate/actions/keyboard_input_action.cpp
> 6438813896850e472a751497dc4b1890db4db869
> libkhotkeysprivate/windows_handler.h
> 1ab070e607cad9a0910627774dd6b3eaa1ebf6be
> libkhotkeysprivate/windows_handler.cpp
> 5a6d0d71fe821c9374c4ed013d63bd3e137b3cc3
>
> Diff: https://git.reviewboard.kde.org/r/125825/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
