Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/ --- (Updated Oct. 11, 2015, 8:10 p.m.) Status -- This change has been ma

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-08 Thread Eike Hein
> On Oct. 8, 2015, 3:44 p.m., Eike Hein wrote: > > Ship It! Looks good, thanks! - Eike --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/#review86510 ---

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-08 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/#review86510 --- Ship it! Ship It! - Eike Hein On Oct. 7, 2015, 9:49 p.m.,

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/ --- (Updated Oct. 7, 2015, 9:49 p.m.) Review request for Plasma. Repository

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-07 Thread David Edmundson
> On Oct. 7, 2015, 8:41 p.m., Eike Hein wrote: > > Right-click an application, re testing question. Oh, I'm super stupid. I was doing that but only getting "Add to favourites". I had got my kicker and kickoff confused and was running the wrong one. - David ---

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-07 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/#review86463 --- Right-click an application, re testing question. - Eike Hein

Re: Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/ --- (Updated Oct. 7, 2015, 1 p.m.) Review request for Plasma. Repository: p

Review Request 125545: Don't start an eventLoop from QML in menu entry editing

2015-10-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/ --- Review request for Plasma. Repository: plasma-desktop Description -