> On Oct. 7, 2015, 8:41 p.m., Eike Hein wrote: > > Right-click an application, re testing question.
Oh, I'm super stupid. I was doing that but only getting "Add to favourites". I had got my kicker and kickoff confused and was running the wrong one. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125545/#review86463 ----------------------------------------------------------- On Oct. 7, 2015, 1 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125545/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 1 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > From the docs: > This is dangerous, because when an event loop is entered in a signal > handler or binding, the QML engine continues to run other bindings, > animations, transitions, etc. Those bindings can then cause side effects > which, for example, destroy the hierarchy containing your event loop. > > There was a queuedConnection approach that I guess tries to supress the > problem, but it clearly didn't work. > In any case, it's better not to freeze the shell > > BUG: 347997 > > > Diffs > ----- > > applets/kicker/plugin/appentry.cpp 45644d4f8b8b4e83debb90e9acaf52db14ead7ec > applets/kicker/plugin/menuentryeditor.cpp > ce202c7ae6540bc7f4e3da53211d224dd9eedce7 > > Diff: https://git.reviewboard.kde.org/r/125545/diff/ > > > Testing > ------- > > Literally none. I can't work out how to trigger the "Edit Application" > option. Help/testing would be appreciated. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
