Re: Review Request 125376: KNotification: don't update notification twice

2015-10-01 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/ --- (Updated Oct. 1, 2015, 2:32 p.m.) Status -- This change has been mar

Re: Review Request 125376: KNotification: don't update notification twice

2015-10-01 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/#review86200 --- Ship it! Ship It! - Martin Klapetek On Sept. 24, 2015, 5:4

Re: Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Igor Poboiko
> On Сен. 24, 2015, 3:56 п.п., Martin Klapetek wrote: > > Thanks for the patch. Is it reproducible with anything else? Also, can you > > point me to the ktp code in question? > > > > Thanks It's [ktp-approver/textchannelapprover.cpp](https://quickgit.kde.org/?p=ktp-approver.git&a=blob&h=b28db

Re: Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/#review85875 --- Thanks for the patch. Is it reproducible with anything else? A

Review Request 125376: KNotification: don't update notification twice

2015-09-24 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/ --- Review request for Plasma and Martin Klapetek. Repository: knotifications