----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125376/ -----------------------------------------------------------
Review request for Plasma and Martin Klapetek. Repository: knotifications Description ------- I've noted a bug when using KDE Telepathy: if I receive 2 new messages, first creates a new notification, and second is being duplicated (see screenshot attached; on it I just wrote myself "hello", then "world"). Investigation showed following: * KTp calls KNotification::setText on existing notification * KNotification starts d->updateTimer, which will update notification in 100 msec * KTp call KNotification::sendEvent, which updates notification * updateTimer expires calling KNotification::update() again, leading to duplicated DBus message and duplicated notification Not sure if there is any bug in BugZilla, but it is 100% reproducible in my case. Diffs ----- src/knotification.cpp cf09e63 Diff: https://git.reviewboard.kde.org/r/125376/diff/ Testing ------- After applying patch it works fine. File Attachments ---------------- The problem https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/161f9955-068a-4b39-85d0-8537b05d9cb2__snapshot22.png Thanks, Igor Poboiko
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
