Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-11-30 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/ --- (Updated Nov. 30, 2015, 2:13 p.m.) Status -- This change has been di

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-23 Thread David Edmundson
> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48 > > > > > > So to make sure I'm clear we want to get > > > > child[0] > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-23 Thread Marco Martin
> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48 > > > > > > So to make sure I'm clear we want to get > > > > child[0] > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-23 Thread David Edmundson
> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48 > > > > > > So to make sure I'm clear we want to get > > > > child[0] > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/ --- (Updated Sept. 22, 2015, 2:35 p.m.) Review request for Plasma. Reposito

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-22 Thread Marco Martin
> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 37 > > > > > > I would avoiding setting width and heights whilst in a RowLayout > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-22 Thread Marco Martin
> On Sept. 22, 2015, 1:22 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml, line 48 > > > > > > So to make sure I'm clear we want to get > > > > child[0] > >

Re: Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-22 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/#review85751 --- src/declarativeimports/plasmacomponents/qml/ToolBarLayout.qml

Review Request 125349: use a RowLayout for ToolbarLayout

2015-09-22 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125349/ --- Review request for Plasma. Repository: plasma-framework Description ---