Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 17, 2015, 10:40 a.m.) Status -- This change has been

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 6:19 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 5:40 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 4:44 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 9:41 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp, line 259 > > > > > > This adds the same item multiple times. > > > > If you have an

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 9:12 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? > > Eike Hein wrote: > It basically triggers

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85466 --- src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp (

Re: Review Request 125226: move EventForge from the desktop containment

> On Sept. 15, 2015, 12:06 a.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/eventforge.cpp, line 51 > > > > > > why do people need to do this? It basically triggers the onCanceled handler in

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:32 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 15, 2015, 5:30 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

On Sept. 15, 2015, 12:06 a.m., Marco Martin wrote: > > This class feels like it's just working round Qt bugs? > > > > Other than that if this is long-term useful, we should do sendPress(flags > > buttons, flags modifiers, x, y) not just whatever AppletAppearance happened > > to need (or make i

Re: Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85410 --- src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27) <

Review Request 125226: move EventForge from the desktop containment

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- Review request for KDE Frameworks, Plasma and Eike Hein. Repository: kdec