Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85164 --- next time please squash the whitespace fix together with the o

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- (Updated Sept. 11, 2015, 9:50 a.m.) Status -- This change has been m

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
> On Sept. 11, 2015, 11:40 a.m., Martin Gräßlin wrote: > > sorry clicked the wrong button. I assume you verified that kdelibs4support > > is only needed in the one sub directory? > > Patrick von Reth wrote: > Which wrong button? The ship it? > Yes I grepped the repo for kdelibs4support

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
> On Sept. 11, 2015, 9:40 vorm., Martin Gräßlin wrote: > > sorry clicked the wrong button. I assume you verified that kdelibs4support > > is only needed in the one sub directory? Which wrong button? The ship it? Yes I grepped the repo for kdelibs4support and Su. - Patrick --

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85161 --- Ship it! sorry clicked the wrong button. I assume you verifie

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85160 --- CMakeLists.txt (line 79)

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- (Updated Sept. 11, 2015, 9:34 vorm.) Review request for Plasma. Reposit

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85159 --- CMakeLists.txt (line 44)

Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- Review request for Plasma. Repository: kde-cli-tools Description --