----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85159 -----------------------------------------------------------
CMakeLists.txt (line 44) <https://git.reviewboard.kde.org/r/125155/#comment58884> please move the Qt5X11Extras into the if(X11_FOUND AND XCB_FOUND) section CMakeLists.txt (line 45) <https://git.reviewboard.kde.org/r/125155/#comment58885> instead of binding it to Unix I suggest to make it an optional dependency and bind the later checks which need it to build only if included. - Martin Gräßlin On Sept. 11, 2015, 10:51 a.m., Patrick von Reth wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125155/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 10:51 a.m.) > > > Review request for Plasma. > > > Repository: kde-cli-tools > > > Description > ------- > > Update dependencies and fix build on Windows. > > > Diffs > ----- > > CMakeLists.txt ca5c6bba4d44953a254d182e097221956b79b252 > kcmshell/CMakeLists.txt a867539b92ddaebee1c6e8f7055f48383ce60f4c > > Diff: https://git.reviewboard.kde.org/r/125155/diff/ > > > Testing > ------- > > Windows > > > Thanks, > > Patrick von Reth > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
