Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/ --- (Updated Sept. 8, 2015, 6:57 a.m.) Status -- This change has been ma

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/#review84989 --- Ship it! Ship It! - David Edmundson On Sept. 8, 2015, 4:09

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
> On Sept. 8, 2015, 6:34 a.m., David Edmundson wrote: > > src/declarativeimports/core/units.h, lines 41-42 > > > > > > size in which direction? > > Bhushan Shah wrote: > s/size of/width of/ > > If yo

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
> On Sept. 8, 2015, 12:04 p.m., David Edmundson wrote: > > src/declarativeimports/core/units.h, lines 41-42 > > > > > > size in which direction? s/size of/width of/ If you don't mind I will fix it when commiting

Re: Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/#review84986 --- src/declarativeimports/core/units.h (lines 41 - 42)

Review Request 125099: Fix documentation for gridUnit

2015-09-07 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework