> On Sept. 8, 2015, 6:34 a.m., David Edmundson wrote: > > src/declarativeimports/core/units.h, lines 41-42 > > <https://git.reviewboard.kde.org/r/125099/diff/1/?file=402190#file402190line41> > > > > size in which direction? > > Bhushan Shah wrote: > s/size of/width of/ > > If you don't mind I will fix it when commiting
:D ok. Can you change M to "of the letter M". Otherwise it seems M is short for something - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125099/#review84986 ----------------------------------------------------------- On Sept. 8, 2015, 4:09 a.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125099/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 4:09 a.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-framework > > > Description > ------- > > Unless I am mistaken, gridUnit clearly doesn't correspond to milimeter but > size of M > > > Diffs > ----- > > src/declarativeimports/core/units.h 6c038ba > > Diff: https://git.reviewboard.kde.org/r/125099/diff/ > > > Testing > ------- > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
