Re: Review Request 125038: Make SourceModel writeable

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 11, 2015, 7:11 p.m.) Status -- This change has been m

Re: Review Request 125038: Make SourceModel writeable

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/#review85169 --- Ship it! Given no-one else has commented... Ship it - David

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 3:13 p.m.) Review request for Plasma and Harald S

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
> On Sept. 7, 2015, 8:40 a.m., David Edmundson wrote: > > src/pulseaudio.cpp, line 379 > > > > > > int QMetaObject::indexOfSignal(const char * signal) const > > > > rather than looping I will also chang

Re: Review Request 125038: Make SourceModel writeable

2015-09-07 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 2:11 p.m.) Review request for Plasma and Harald S

Re: Review Request 125038: Make SourceModel writeable

2015-09-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/#review84933 --- src/pulseaudio.cpp (line 379)

Re: Review Request 125038: Make SourceModel writeable

2015-09-06 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 7, 2015, 3:01 a.m.) Review request for Plasma and Harald S

Review Request 125038: Make SourceModel writeable

2015-09-03 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- Review request for Plasma. Repository: plasma-pa Description --- T