----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/#review84933 -----------------------------------------------------------
src/pulseaudio.cpp (line 379) <https://git.reviewboard.kde.org/r/125038/#comment58751> int QMetaObject::indexOfSignal(const char * signal) const rather than looping - David Edmundson On Sept. 7, 2015, 1:01 a.m., David Kahles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125038/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2015, 1:01 a.m.) > > > Review request for Plasma and Harald Sitter. > > > Repository: plasma-pa > > > Description > ------- > > This is needed in order to change the input device volume from the applet > It's mostly copied and adjusted from the SinkModel. > It would be better to move this into the AbstractModel class, but I don't > know how to do this, given that the moc can't handle templates. > > > Diffs > ----- > > src/pulseaudio.h e9402cfd2ea53290c1c2d00373bd5d5657c1bde5 > src/pulseaudio.cpp 911088aab10dcc76208b7c36eaa60ab9b79298ad > > Diff: https://git.reviewboard.kde.org/r/125038/diff/ > > > Testing > ------- > > Changing the input volume from the applet works fine now (testes with skype > and pavucontrol) > > > Thanks, > > David Kahles > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
