Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Oct. 30, 2015, 12:09 p.m.) Status -- This change has been m

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review87318 --- Ship it! Ship It! - Marco Martin On Oct. 18, 2015, 11:46 a

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Okt. 18, 2015, 11:46 vorm.) Review request for Plasma and Martin

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review86996 --- overall looks good to me. Thanks for changing to generating co

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Okt. 17, 2015, 5:59 nachm.) Review request for Plasma and Martin

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Okt. 17, 2015, 1:59 nachm.) Review request for Plasma and Martin

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review85080 --- components/sessionsprivate/sessionsmodel.cpp (line 30)

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- (Updated Sept. 9, 2015, 8:28 nachm.) Review request for Plasma and Martin

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

> On Aug. 31, 2015, 8:25 a.m., Martin Gräßlin wrote: > > components/sessionsprivate/sessionsmodel.h, line 56 > > > > > > suggestion: enum class, and then drop the Role from each name. Usage > > will be e.g. Roles

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

> On Aug. 31, 2015, 6:25 vorm., Martin Gräßlin wrote: > > components/sessionsprivate/sessionsmodel.h, line 56 > > > > > > suggestion: enum class, and then drop the Role from each name. Usage > > will be e.g. Role

Re: Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review84618 --- components/sessionsprivate/sessionsmodel.h (line 56)

Review Request 124980: Add org.kde.plasma.private.sessions with a SessionModel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/ --- Review request for Plasma and Martin Gräßlin. Repository: plasma-workspac