> On Aug. 31, 2015, 6:25 vorm., Martin Gräßlin wrote: > > components/sessionsprivate/sessionsmodel.h, line 56 > > <https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line56> > > > > suggestion: enum class, and then drop the Role from each name. Usage > > will be e.g. Roles::Icon
I don't think that'll work given QAbstractItemModel passes roles around as int and you cannot implicitly convert an enum class to int? > On Aug. 31, 2015, 6:25 vorm., Martin Gräßlin wrote: > > components/sessionsprivate/sessionsmodel.h, line 83 > > <https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line83> > > > > Is KDisplayManager using (blocking) DBus calls? If yes, I think we > > should design this to get it async. I suppose given how old it is > On Aug. 31, 2015, 6:25 vorm., Martin Gräßlin wrote: > > components/sessionsprivate/sessionsmodel.h, line 85 > > <https://git.reviewboard.kde.org/r/124980/diff/1/?file=399560#file399560line85> > > > > Playing Milian: cetero censeo QList delendam esset. > > > > -> use QVector ;-) I though QList was only evil if sizeof T is <= void* ? - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124980/#review84618 ----------------------------------------------------------- On Aug. 29, 2015, 2:14 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124980/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2015, 2:14 nachm.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This way it can be used in the lock screen, user switcher, and a user > switcher plasmoid I'm planning. > > Compared to the one in the lock screen it can also get the user's full name > and avatar, and some other information. > > Perhaps we could also try to have it wait for the screen to actually lock > before switching sessions? > > > Diffs > ----- > > components/CMakeLists.txt 21fc61c > components/sessionsprivate/CMakeLists.txt PRE-CREATION > components/sessionsprivate/qmldir PRE-CREATION > components/sessionsprivate/sessionsmodel.h PRE-CREATION > components/sessionsprivate/sessionsmodel.cpp PRE-CREATION > components/sessionsprivate/sessionsprivateplugin.h PRE-CREATION > components/sessionsprivate/sessionsprivateplugin.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/124980/diff/ > > > Testing > ------- > > Lists my sessions, allows to switch between them and start new ones. Locking > when creating a new session is missing. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
