Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-30 Thread David Edmundson
> On Aug. 30, 2015, 1:28 p.m., David Edmundson wrote: > > This needs reverting. > > > > Check wallpaper configuration now. Explaining this a bit better. What the code was doing before: height is either: the size of the child items filling up all the way to the buttons at the bottom of

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/#review84578 --- This needs reverting. Check wallpaper configuration now. - D

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/ --- (Updated Aug. 27, 2015, 4:47 p.m.) Status -- This change has been ma

Re: Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/#review84478 --- Ship it! Ship It! - Marco Martin On Aug. 27, 2015, 2:12 p.

Review Request 124953: [Appletconfiguration] Prevent binding loop in main stackview

2015-08-27 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/ --- Review request for Plasma. Repository: plasma-desktop Description -