----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124953/#review84478 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Aug. 27, 2015, 2:12 p.m., David Kahles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124953/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 2:12 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Calculate the height of the stackview without using the viewport height > to prevent a binding loop, because te viewportheight changes when the > stackviewheight changes. Thus, the height of the main stackview could > not be reduced but only increased. > > Please double check as I don't know much about applets in generell.. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml > 0302c7a572d0e4567677ea95e5606427537fa3ff > > Diff: https://git.reviewboard.kde.org/r/124953/diff/ > > > Testing > ------- > > The height of the main stackview in the pa-applet configuration couldn't be > decreased which led to an unnecessary scrollbar and a binding loop warning. > After applying this patch, the height can be decreased and the scrollbar and > the warning disappeared. > I coundn't find this bug in any other applet configurations. (Maybe they're > using different technics, don't know that) > > > Thanks, > > David Kahles > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
