Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 11, 2015, 11:05 a.m.) Status -- This change has been m

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83697 --- Ship it! - David Faure On Aug. 5, 2015, 10:41 p.m., Sebasti

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-11 Thread Sebastian Kügler
> On Aug. 6, 2015, 7:13 a.m., David Faure wrote: > > If the goal is to query this property for the K menu for instance, aren't > > you missing an accessor in KService? OK, on the other hand, if this is the > > only user, then property("...") would do too, but still, compile-time > > checking i

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-06 Thread Sebastian Kügler
> On Aug. 6, 2015, 7:13 a.m., David Faure wrote: > > If the goal is to query this property for the K menu for instance, aren't > > you missing an accessor in KService? OK, on the other hand, if this is the > > only user, then property("...") would do too, but still, compile-time > > checking i

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83476 --- If the goal is to query this property for the K menu for insta

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- (Updated Aug. 5, 2015, 10:41 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/#review83468 --- Looks good to me, just two small things. autotests/kservicet

Review Request 124633: Parse formfactor in KService and KPluginInfo

2015-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124633/ --- Review request for KDE Frameworks, Plasma, Alex Richardson, and David Faure