Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
> On Čec. 27, 2015, 12:57 odp., Lamarque Souza wrote: > > applet/contents/ui/ConnectionItem.qml, line 306 > > > > > > what's the update rate used here? I think it is still 1 second. The old > > Plasma NM used to

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/ --- (Updated July 27, 2015, 1:08 p.m.) Status -- This change has been ma

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83041 --- applet/contents/ui/ConnectionItem.qml (line 306)

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83040 --- Ship it! Ship It! - David Edmundson On July 27, 2015, 10:5

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
> On Čec. 27, 2015, 11:12 dop., David Edmundson wrote: > > applet/contents/ui/ConnectionItem.qml, line 292 > > > > > > I don't get why 5? Because there are 5 lines in the plotter. > On Čec. 27, 2015, 11:12 dop

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread David Edmundson
> On July 27, 2015, 10:47 a.m., Heiko Tietze wrote: > > Why are the graphs such unrealistic shaped? Looks like heavy filtering. If > > Thomas and Jens granted usability I will check the ship it here. But please > > discuss also the scaling method. When it is adopted to the current speed > > th

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83030 --- applet/contents/ui/ConnectionItem.qml (line 292)

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/ --- (Updated Čec. 27, 2015, 10:55 dop.) Review request for Network Management

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
> On Čec. 27, 2015, 10:47 dop., Heiko Tietze wrote: > > Why are the graphs such unrealistic shaped? Looks like heavy filtering. If > > Thomas and Jens granted usability I will check the ship it here. But please > > discuss also the scaling method. When it is adopted to the current speed > > th

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83033 --- Ship it! Why are the graphs such unrealistic shaped? Looks li

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread David Edmundson
> On July 27, 2015, 10:13 a.m., David Edmundson wrote: > > screenshot and add usability? > > Jan Grulich wrote: > Added screenshot and usability group. I also already talked to Thomas and > Jens and they are fine with this change. ah, that's all I needed to hear :) - David

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/ --- (Updated Čec. 27, 2015, 10:17 dop.) Review request for Network Management

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
> On Čec. 27, 2015, 10:13 dop., David Edmundson wrote: > > screenshot and add usability? Added screenshot and usability group. I also already talked to Thomas and Jens and they are fine with this change. - Jan --- This is an automatica

Re: Review Request 124485: Add missing traffic monitor

2015-07-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/#review83026 --- screenshot and add usability? - David Edmundson On July 27,

Review Request 124485: Add missing traffic monitor

2015-07-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124485/ --- Review request for Network Management and Plasma. Bugs: 268022 http:/