Re: Review Request 124151: Add a default icon to notifications popup

2015-06-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ --- (Updated June 25, 2015, 9:39 a.m.) Status -- This change has been ma

Re: Review Request 124151: Add a default icon to, notifications popup

2015-06-23 Thread Xen
plasma-devel-requ...@kde.org schreef op 23-6-2015 om 18:22: Today's Topics: 1. Re: Review Request 124151: Add a default icon to notifications popup (Eike Hein) 2. Re: Plasma-devel Digest, Vol 84, Issue 78 (Xen) 3. Re: Review Request 124151: Add a default ic

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Xen
/ On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: />>/ > I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now />>/ />>/ Philipp A. wrote: />>/ i also like the no-icon no-space version. why add something that just takes up unneces

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81712 --- Ship it! Looks cleaner indeed, thanks. - Sebastian Kügler

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Martin Klapetek
On Tue, Jun 23, 2015 at 5:46 PM, Xen wrote: > > >>* On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: > *>>* > I actually really like it, perhaps we should make KDialog passive > popup not set an icon by default now > *>> >>* Philipp A. wrote: > *>>* i also like the no-icon no-space vers

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Xen
/ On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: />>/ > I actually really like it, perhaps we should make KDialog passive popup not set an icon by default now />>/ />>/ Philipp A. wrote: />>/ i also like the no-icon no-space version. why add something that just takes up unnec

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Eike Hein
> On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: > > I actually really like it, perhaps we should make KDialog passive popup not > > set an icon by default now > > Philipp A. wrote: > i also like the no-icon no-space version. why add something that just > takes up unnecessary space a

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Philipp A.
> On June 23, 2015, 10:40 a.m., Kai Uwe Broulik wrote: > > I actually really like it, perhaps we should make KDialog passive popup not > > set an icon by default now i also like the no-icon no-space version. why add something that just takes up unnecessary space and has no informational value?

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81698 --- I actually really like it, perhaps we should make KDialog pass

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ --- (Updated June 23, 2015, 11:42 a.m.) Review request for Plasma. Changes

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Andrew Lake
> On June 22, 2015, 5:54 p.m., Kai Uwe Broulik wrote: > > what about just freeing the space instead? i'm find with this solution > > though > > Martin Klapetek wrote: > I didn't do that for two reasons - apps/commands setting no icon would > just look out of place with their notification.

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Marco Martin
> On June 22, 2015, 5:54 p.m., Kai Uwe Broulik wrote: > > what about just freeing the space instead? i'm find with this solution > > though > > Martin Klapetek wrote: > I didn't do that for two reasons - apps/commands setting no icon would > just look out of place with their notification.

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Sebastian Kügler
> On June 22, 2015, 5:54 p.m., Kai Uwe Broulik wrote: > > what about just freeing the space instead? i'm find with this solution > > though > > Martin Klapetek wrote: > I didn't do that for two reasons - apps/commands setting no icon would > just look out of place with their notification.

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81676 --- Ship it! applets/notifications/package/contents/ui/Notificat

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Martin Klapetek
> On June 22, 2015, 7:54 p.m., Kai Uwe Broulik wrote: > > what about just freeing the space instead? i'm find with this solution > > though I didn't do that for two reasons - apps/commands setting no icon would just look out of place with their notification. Second is that the icon plays an i

Re: Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81666 --- what about just freeing the space instead? i'm find with this

Review Request 124151: Add a default icon to notifications popup

2015-06-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ --- Review request for Plasma. Repository: plasma-workspace Description ---