> On June 22, 2015, 5:54 p.m., Kai Uwe Broulik wrote: > > what about just freeing the space instead? i'm find with this solution > > though > > Martin Klapetek wrote: > I didn't do that for two reasons - apps/commands setting no icon would > just look out of place with their notification. Second is that the icon plays > an important part in the layout - it sets min height as well as having > anchors attached to it. It could be changed but would make the layouting more > complex imo, which is not worth it for the reason #1. > > Sebastian Kügler wrote: > I'm on the fence here as well. If we can remove an icon that doesn't bear > any semantic meaning (the notification popups share, location and appearance > already conveys "this is a notification". If we can avoid clutter, that's > always a good thing. > > I think the reasons Martin gives are invalid from a user point of view > (adding an icon to fix layout sizing seems wrong). > > Marco Martin wrote: > freeing more space is good, but if a stack of notifications has some with > and some without it may look inconsistent
Hmm, I totally understand the intent of adding the icon to make the layout consistent for all notifications. I do think two proper layout designs, one with icon and one without, may be the best way to handle it. Yes, it would introduce a potential visual inconsistency, but no more inconsistency than the semantics of the notification content. But, if it's a choice betweeen this patch and doing nothing, I'll take this patch. :-) - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/#review81666 ----------------------------------------------------------- On June 22, 2015, 5:51 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124151/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 5:51 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Currently there's none and if there's just a summary text ($ notify-send > text), the notification popup looks strange. Adding the default icon makes it > look more consistent and not totally-out-of-place-command-line-notification. > > > Diffs > ----- > > applets/notifications/package/contents/ui/Notifications.qml 13be7d4 > > Diff: https://git.reviewboard.kde.org/r/124151/diff/ > > > Testing > ------- > > See screenshot > > > File Attachments > ---------------- > > Screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
