Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- (Updated June 15, 2015, 2:35 p.m.) Status -- This change has been ma

Re: Review Request 124072: Refactor the Calendar grid computation a bit

> On Juni 12, 2015, 9:34 nachm., Kai Uwe Broulik wrote: > > Ship It! Just one minor nitpick: it doesn't repaint the grid when theme changes: Connections { target: theme onTextColorChanged: canvas.requestPaint() } - Kai Uwe

Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/#review81431 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 11, 2015, 11:1

Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- (Updated June 12, 2015, 1:18 a.m.) Review request for Plasma. Changes -

Re: Review Request 124072: Refactor the Calendar grid computation a bit

> On jun 11, 2015, 3:38 p.m., Mark Gaiser wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 42-43 > > > > > > Can you fix the double root.borderWidth addition? It looks odd. > > > > I

Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- (Updated June 11, 2015, 7:36 p.m.) Review request for Plasma. Changes -

Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- (Updated June 11, 2015, 7:23 p.m.) Review request for Plasma. Changes -

Re: Review Request 124072: Refactor the Calendar grid computation a bit

> On June 11, 2015, 5:38 p.m., Mark Gaiser wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 42-43 > > > > > > Can you fix the double root.borderWidth addition? It looks odd. > > > >

Re: Review Request 124072: Refactor the Calendar grid computation a bit

> On June 11, 2015, 5:38 p.m., Mark Gaiser wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 42-43 > > > > > > Can you fix the double root.borderWidth addition? It looks odd. > > > >

Re: Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/#review81382 --- src/declarativeimports/calendar/qml/DaysCalendar.qml (lines 3

Review Request 124072: Refactor the Calendar grid computation a bit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- Review request for Plasma. Repository: plasma-framework Description ---