> On Juni 12, 2015, 9:34 nachm., Kai Uwe Broulik wrote:
> > Ship It!
Just one minor nitpick: it doesn't repaint the grid when theme changes:
Connections {
target: theme
onTextColorChanged: canvas.requestPaint()
}
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124072/#review81431
-----------------------------------------------------------
On Juni 11, 2015, 11:18 nachm., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124072/
> -----------------------------------------------------------
>
> (Updated Juni 11, 2015, 11:18 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Makes the code a bit simpler & lighter and fixes the sometimes missing bottom
> line in calendar.
>
> The grid is now equally padded from both sides (including the month name), so
> basically it's now
> always aligned to the center and this also fixes the cases where there was a
> bigger padding on
> one side than on the other.
>
> The grid is now also anchored to the bottom so that the bottom margin can
> stay moreless consistent
> with the side margins in different sizes.
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/DaysCalendar.qml 5308708
> src/declarativeimports/calendar/qml/MonthView.qml 86e37d8
>
> Diff: https://git.reviewboard.kde.org/r/124072/diff/
>
>
> Testing
> -------
>
> Lots of 600x-zoom inspections and pixel counting. Tested both in Calendar
> applet and Digital Clock applet.
>
>
> Thanks,
>
> Martin Klapetek
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
