Re: Review Request 122717: Improve tooltip layouting

2015-03-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review77060 --- src/declarativeimports/core/private/DefaultToolTip.qml

Re: Review Request 122717: Improve tooltip layouting

2015-03-05 Thread Martin Klapetek
> On Feb. 26, 2015, 11:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-03-05 Thread David Edmundson
> On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-03-02 Thread Sebastian Kügler
> On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-03-02 Thread Martin Klapetek
> On Feb. 26, 2015, 11:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-02-27 Thread Sebastian Kügler
> On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-02-26 Thread Lukáš Tinkl
> On Úno. 26, 2015, 11:10 odp., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122717: Improve tooltip layouting

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76692 --- I'm now getting most of my headlines elided or wrapped: "K-\n

Re: Review Request 122717: Improve tooltip layouting

2015-02-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 26, 2015, 3:46 p.m.) Status -- This change has been ma

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76636 --- Ship it! Ship It! - David Edmundson On Feb. 25, 2015, 8:31

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76637 --- src/declarativeimports/core/private/DefaultToolTip.qml

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 8:31 p.m.) Review request for Plasma. Changes -

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76633 --- src/declarativeimports/core/private/DefaultToolTip.qml

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 5:27 p.m.) Review request for Plasma. Changes -

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- (Updated Feb. 25, 2015, 5:16 p.m.) Review request for Plasma. Changes -

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Marco Martin
> On Feb. 25, 2015, 10:23 a.m., David Edmundson wrote: > > src/declarativeimports/core/private/DefaultToolTip.qml, line 96 > > > > > > just set the Layout.preferredWidth instead of min and max. > > (and on the

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Sebastian Kügler
> On Feb. 25, 2015, 10:23 a.m., David Edmundson wrote: > > src/declarativeimports/core/private/DefaultToolTip.qml, line 96 > > > > > > just set the Layout.preferredWidth instead of min and max. > > (and on the

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76596 --- +1 I like how it makes use of layouts with this approach. - A

Re: Review Request 122717: Improve tooltip layouting

2015-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/#review76591 --- +1 to the approach. It's a lot neater, and I love layouts

Review Request 122717: Improve tooltip layouting

2015-02-24 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ --- Review request for Plasma. Repository: plasma-framework Description ---