----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122717/ -----------------------------------------------------------
(Updated Feb. 26, 2015, 3:46 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-framework Description ------- Improve tooltip layouting This patch ports the default tooltip away from custom spacing, positioning and Row/Column to QtQuick.Layouts. It makes the sizing more predictable, and the code more modern and readable. Tooltips feel to behave a bit smoother with this patch. In the process, this... - fixes spacing when no icon or image is set - limits the maximum height of the subtext to 8 lines (this prevents the klipper tooltip for example from growing super-high) - Makes the icon on the LHS proportional to the text - Limits the width a bit more to prevent super-wide tooltips - makes it use units.gridUnit throughout Changelog: Improve tooltip layout This is the more radical approach to https://git.reviewboard.kde.org/r/122715/ Diffs ----- src/declarativeimports/core/private/DefaultToolTip.qml d1be6ae Diff: https://git.reviewboard.kde.org/r/122717/diff/ Testing ------- Tested all applets' tooltips in the default panel File Attachments ---------------- launcher (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/a6c636ce-3aef-4d5a-82f0-d78f9dab19a1__old-kickoff.png pager (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fae793bb-2965-4a81-be27-08efce5b3838__old-pager.png kdeconnect (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/fc079c52-be17-47cf-bd11-976aed566155__old-kdeconnect.png clock (old) https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/8214146b-cdd4-41d7-b406-f6fc404585cc__old-clock.png new-kickoff.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/9a96304f-1deb-4f57-9417-121a95b7ed03__new-kickoff.png new-pager.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/e2c5738f-e701-4a5e-a179-cedc6bb55181__new-pager.png new-kdeconnect.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/0c73a854-de8a-4dc2-bd57-c22e0700dbb5__new-kdeconnect.png new-clock.png https://git.reviewboard.kde.org/media/uploaded/files/2015/02/25/7311d304-cdf3-4bf2-8fdc-519d1a4c020d__new-clock.png Thanks, Sebastian Kügler
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
