Re: Review Request 122648: Make notifications --reverse aware

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- (Updated May 18, 2015, 12:54 p.m.) Status -- This change has been ma

Re: Review Request 122648: Make notifications --reverse aware

2015-02-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- (Updated Feb. 23, 2015, 1:13 p.m.) Review request for Plasma. Changes -

Re: Review Request 122648: Make notifications --reverse aware

2015-02-21 Thread Martin Klapetek
> On Feb. 20, 2015, 4:03 p.m., David Edmundson wrote: > > applets/notifications/package/contents/ui/NotificationItem.qml, line 132 > > > > > > Just > > LayoutMirroring.enabled: true > > > > and then

Re: Review Request 122648: Make notifications --reverse aware

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/#review76364 --- Ship it! Ship It! - Marco Martin On Feb. 20, 2015, 8:07 p.

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- (Updated Feb. 20, 2015, 9:07 p.m.) Review request for Plasma. Changes -

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- (Updated Feb. 20, 2015, 9:06 p.m.) Review request for Plasma. Changes -

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Martin Klapetek
> On Feb. 20, 2015, 5:47 p.m., Kai Uwe Broulik wrote: > > Just place the following on the root item > > > > LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > > LayoutMirroring.childrenInherit: true > > > > No need to adjust individual anchors > > Martin Klapetek wrot

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Martin Klapetek
> On Feb. 20, 2015, 5:47 p.m., Kai Uwe Broulik wrote: > > Just place the following on the root item > > > > LayoutMirroring.enabled: Qt.application.layoutDirection === Qt.RightToLeft > > LayoutMirroring.childrenInherit: true > > > > No need to adjust individual anchors Nope. http://imgur.com/x

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/#review76344 --- Just place the following on the root item LayoutMirroring.ena

Re: Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/#review76339 --- applets/notifications/package/contents/ui/NotificationItem.qm

Review Request 122648: Make notifications --reverse aware

2015-02-20 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- Review request for Plasma. Bugs: 343251 https://bugs.kde.org/show_bug