> On Feb. 20, 2015, 4:03 p.m., David Edmundson wrote: > > applets/notifications/package/contents/ui/NotificationItem.qml, line 132 > > <https://git.reviewboard.kde.org/r/122648/diff/1/?file=350380#file350380line132> > > > > Just > > LayoutMirroring.enabled: true > > > > and then it will swap only if layoutDirection == RTL > > otherwise we're implicitly checking twice. > > > > > > https://paste.kde.org/pl8jqrfzl <--- proof.
Turns out simply ": true" is not correct; now after computer restart I have the notifications mirrored while everything else is not. (and it's not running --reverse). I'll put the check back (it's in Qt's examples too). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/#review76339 ----------------------------------------------------------- On Feb. 20, 2015, 9:07 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122648/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2015, 9:07 p.m.) > > > Review request for Plasma. > > > Bugs: 343251 > https://bugs.kde.org/show_bug.cgi?id=343251 > > > Repository: plasma-workspace > > > Description > ------- > > Now it works with plasmashell --reverse > > > Diffs > ----- > > applets/notifications/plugin/notificationshelper.cpp e7c4e29 > applets/notifications/package/contents/ui/main.qml 1e5efa3 > applets/notifications/plugin/notificationshelper.h ca0b63b > applets/notifications/package/contents/ui/NotificationPopup.qml 6902459 > applets/notifications/package/contents/ui/NotificationItem.qml 86b0b6e > > Diff: https://git.reviewboard.kde.org/r/122648/diff/ > > > Testing > ------- > > Tested both --reverse and not --reverse and both look good. See screenshot. > > > File Attachments > ---------------- > > --reverse > > https://git.reviewboard.kde.org/media/uploaded/files/2015/02/20/5058fe12-ecdd-4345-bcec-4392bbfa78f5__notifications-reverse.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
