Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update your plasma-workspace, I've adjusted b

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update your plasma-workspace, I've adjusted b

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update your plasma-workspace, I've adjusted

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update your plasma-workspace, I've adjusted b

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update your plasma-workspace, I've adjusted

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71445 --- i've lost brightness control in battery monitor after this cha

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dez. 5, 2014, 11:39 nachm., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway Please update your plasma-workspace, I've adjusted battery monitor accordingly. -

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- (Updated Dec. 5, 2014, 9:06 p.m.) Status -- This change has been mar

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71408 --- Ship it! Ship It! - Marco Martin On Dec. 4, 2014, 8:41 p.m

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71394 --- +1 I don't really understand dataengines enough to say it's a

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. > > Ka

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dec. 4, 2014, 10:20 p.m., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. > > Kai

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

> On Dez. 4, 2014, 9:20 nachm., Emmanuel Pescosta wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 170 > > > > > > You can remove the "this" receiver here and in other connect calls. Are yo

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/#review71367 --- dataengines/powermanagement/powermanagementengine.cpp

Review Request 121355: Expose actual and maximum brightness value in dataengine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121355/ --- Review request for Plasma and Solid. Repository: plasma-workspace Descr