Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-11-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/ --- (Updated Nov. 3, 2014, 8:45 a.m.) Status -- This change has been mar

Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-11-03 Thread Martin Gräßlin
> On Nov. 1, 2014, 5:58 p.m., Mark Gaiser wrote: > > Just out of curiosity. Do you have any benchmark numbers? I bet it's > > faster, but by how much in terms of percentage? no I don't have a benchmark. But the worst performance bug we ever had in KWin was accessing a Qt container class using

Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-11-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/#review69649 --- Just out of curiosity. Do you have any benchmark numbers? I be

Re: Review Request 120913: [kcms/lnf] Make a list variable const

2014-10-31 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/#review69578 --- Ship it! Inviala! - Marco Martin On Ott. 31, 2014, 11:13 a

Review Request 120913: [kcms/lnf] Make a list variable const

2014-10-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/ --- Review request for Plasma. Repository: plasma-desktop Description -