----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120913/#review69649 -----------------------------------------------------------
Just out of curiosity. Do you have any benchmark numbers? I bet it's faster, but by how much in terms of percentage? - Mark Gaiser On okt 31, 2014, 11:13 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120913/ > ----------------------------------------------------------- > > (Updated okt 31, 2014, 11:13 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The dataPath variable is used in an extended for-loop as of C++11. > As the variable was not const the for loop uses the more expensive > iterators which allow modification of the list. By making the list > const it can use the better const iterator. > > See http://blog.qt.digia.com/blog/2011/05/26/cpp0x-in-qt/ > > > Diffs > ----- > > kcms/lookandfeel/kcm.cpp a46774200c0c378485a474ff538294c7617ef6d2 > > Diff: https://git.reviewboard.kde.org/r/120913/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
