Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2017-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review102452 --- If this patch is still relevant please reopen on http://phab

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2017-02-08 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Feb. 8, 2017, 12:05 p.m.) Status -- This change has been di

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Ashish Bansal
> On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: > > browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 > > > > > > where do you get these from? > > Ashish Bansal wrote: > I made these keys

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Bhushan Shah
> On Nov. 3, 2014, 9:18 a.m., Shantanu Tushar wrote: > > browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 > > > > > > where do you get these from? > > Ashish Bansal wrote: > I made these keys

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-03 Thread Ashish Bansal
> On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: > > Thanks for your time on this, good stuff :) Tried it and the only caveat is > > that after login is done I have to press the back button (the one on the > > pmc controller) to get my album list. That should be fixed. Yeah I also figured

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- Thanks for your time on this, good stuff :) Tried it and the o

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libra

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Bhushan Shah
> On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote: > > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 > > > > > > Don't use find_libarary as well as never hardcode locations. Instead > > use find_pac

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:17 p.m.) Review request for KDEPIM, KDEPIM-Libra

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
> On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: > > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 > > > > > > Don't use find_libarary as well as never hardcode locations. Instead > > use find_pac

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Bhushan Shah
> On Nov. 2, 2014, 7:01 p.m., Bhushan Shah wrote: > > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 > > > > > > Don't use find_libarary as well as never hardcode locations. Instead > > use find_pac

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Ashish Bansal
> On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: > > browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 > > > > > > Don't use find_libarary as well as never hardcode locations. Instead > > use find_pac

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-11-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- browsingbackends/onlineservices/picasa/CMakeLists.txt

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libr

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Aleix Pol Gonzalez
> On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: > > I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? > > Ashish Bansal wrote: > Well I don't know about KAccounts(Just heard once about it from here : > http://lists.kde.org/?l=kde-devel&m=141434675118408&w=2). Is t

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
> On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: > > I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-devel&m=141434675118408&w=2). Is there any limitation of libkgapi2

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- I'm sorry if it's off-topic, but shouldnt' this be using KAcco

Review Request 120855: Add Google two-step verification support to PMC Picasa login

2014-10-28 Thread Ashish Bansal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and